java filecopy program for .pdf files getting currupted file in output

Question

I wrote this program to copy one pdf file to other but I'm getting curupt fiel in o/p for .txt files this code is working fine.

code:

public class FileCopy {

    public static void main(String args[]) {

        try {
            FileInputStream fs = new FileInputStream("C:\\dev1.pdf");
            byte b;
            FileOutputStream os = new FileOutputStream("C:\\dev2.pdf");
            while ((b = (byte) fs.read()) != -1) {
                os.write(b);
            }
            os.close();
            fs.close();
        } catch (Exception E) {
            E.printStackTrace();
        }
    }
}

I guess the problem is that I'm reading the data byte by byte , because when I'm using read(byte []) method the code is working fine. — decoder
– decoder, Commented Dec 18, 2012 at 13:12

assylias · Accepted Answer · 2012-12-18 13:10:38Z

4

It's because you are mixing ints and bytes. This should work as expected:

int b;
while ((b = fs.read()) != -1) {
    os.write(b);
}

In particular, when fs.read() returns 255, (byte) fs.read returns -1.

answered Dec 18, 2012 at 13:10

assylias

330k84 gold badges680 silver badges806 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Manse · Accepted Answer · 2012-12-18 13:45:47Z

3

try this

try {          
   FileInputStream fs = new FileInputStream("C:\\dev1.pdf");

   FileOutputStream os = new FileOutputStream("C:\\dev2.pdf");
   while ((int b = (byte) fs.read()) != -1) {
       os.write(b);
   }
   os.close();
   fs.close();
} catch (Exception E) {
    E.printStackTrace();
}

edited Dec 18, 2012 at 13:45

Manse

38.1k11 gold badges88 silver badges112 bronze badges

answered Dec 18, 2012 at 13:25

nick_27

663 bronze badges

1 Comment

Sahil Mahajan Mj Over a year ago

This is a good answer though. try to add some explanation to your answer in future.

Collectives™ on Stack Overflow

java filecopy program for .pdf files getting currupted file in output

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related