nested if else in javascript

Question

I have trouble with the nested if structure in javascript. Any help is appreciated.

function validateForm()
{
    var a = document.forms["demo1"]["addr1"].value;
    var b = document.forms["demo1"]["city"].value;
    //var c = document.forms["demo1"]["fname"].value;
    //var d = document.forms["demo1"]["lname"].value;
    //var f = document.forms["demo1"]["phno"].value;
    //var g = document.forms["demo1"]["email"].value;
    //var g1 = document.forms["demo1"]["cemail"].value;
    //var h = document.forms["demo1"]["pwd"].value;
    //var h1 = document.forms["demo1"]["cpwd"].value;
    if(b=="" || b==null)
    {
      alert("Please enter your city");
      return false;
      break;
    }
    else if(a=="" || a==null)
        {
            alert("Please enter your address");
            return false;
            break;
        }
    else {return true;} 
}

<form name = "demo1" action = "exp2.php" onsubmit = "return validateForm()" method = "POST">

The code works fine(as intended) if there is only one if statement. But I am not getting the intended result if more than one if else is been deployed.

Regards, Mani

why there is a break

Arun P Johny
– Arun P Johny

2013-03-20 04:58:10 +00:00
Commented Mar 20, 2013 at 4:58 — Arun P Johny
– Arun P Johny, Commented Mar 20, 2013 at 4:58
seems fine to me jsfiddle.net/arunpjohny/EsJXu

Arun P Johny
– Arun P Johny

2013-03-20 05:01:26 +00:00
Commented Mar 20, 2013 at 5:01 — Arun P Johny
– Arun P Johny, Commented Mar 20, 2013 at 5:01

paxdiablo · Accepted Answer · 2013-03-20 05:00:55Z

5

First, you don't need break statements, they're useless in this context.

Second, you don't need to nest and, in fact, you shouldn't since checking of a and b is independent of each other:

if(b=="" || b==null)
{
    alert("Please enter your city");
    return false;
}

if(a=="" || a==null)
{
    alert("Please enter your address");
    return false;
}

return true;

answered Mar 20, 2013 at 5:00

paxdiablo

889k243 gold badges1.6k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rab · Accepted Answer · 2013-03-20 05:33:56Z

1

What about shorten ur code with reusable isEmpty function

function validateForm()
{

    var isEmpty = function ( name , label ){

          var val = document.forms["demo1"][ name ].value;

          if( ! val  )
          {
               alert("Please enter your "+ label );
               return true;     
          }

          return false;

    }         

    return !isEmpty( 'city', 'city') && 
           !isEmpty( 'addr1', 'address');

}

isEmpty return true or false

answered Mar 20, 2013 at 5:33

rab

4,1641 gold badge32 silver badges42 bronze badges

Comments

Ronak Jain · Accepted Answer · 2018-01-08 12:33:39Z

0

if(b=="" || b==null) {
alert("Please enter your city");
return false;
}
else if(a=="" || a==null) {
alert("Please enter your address");
return false;
}
else {
return true;
}

answered Jan 8, 2018 at 12:33

Ronak Jain

334 bronze badges

Comments

Richard Deurwaarder · Accepted Answer · 2018-03-24 19:51:06Z

0

Like paxdiablo says you can use two separate if statements.

But if you only want to require an address when a city is entered you must realize that this is not a nested if statement. This is:

if(b=="" || b==null)
{
  alert("Please enter your city");
  return false;
}
else 
{
    if(a=="" || a==null)
    {
        alert("Please enter your address");
        return false;
    }
    else 
    {
        return true;
    }
}

A more reabable version would be, imo:

if(b=="" || b==null)
{
  alert("Please enter your city");
  return false;
}

if((b=="" || b == null) && (a=="" || a==null))
{
    alert("Please enter your address");
    return false;
}

edited Mar 24, 2018 at 19:51

answered Mar 20, 2013 at 5:11

Richard Deurwaarder

2,0501 gold badge27 silver badges42 bronze badges

Collectives™ on Stack Overflow

nested if else in javascript

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related