is String.Contains() faster than walking through whole array of char in string?

Question

I have a function that is walking through the string looking for pattern and changing parts of it. I could optimize it by inserting

if (!text.Contains(pattern)) return;

But, I am actually walking through the whole string and comparing parts of it with the pattern, so the question is, how String.Contains() actually works? I know there was such a question - How does String.Contains work? but answer is rather unclear. So, if String.Contains() walks through the whole array of chars as well and compare them to pattern I am looking for as well, it wouldn't really make my function faster, but slower.

So, is it a good idea to attempt such an optimizations? And - is it possible for String.Contains() to be even faster than function that just walk through the whole array and compare every single character with some constant one?

Here is the code:

    public static char colorchar = (char)3;

    public static Client.RichTBox.ContentText color(string text, Client.RichTBox SBAB)
    {
        if (text.Contains(colorchar.ToString()))
        {
            int color = 0;
            bool closed = false;
            int position = 0;
            while (text.Length > position)
            {
                if (text[position] == colorchar)
                {
                    if (closed)
                    {
                        text = text.Substring(position, text.Length - position);
                        Client.RichTBox.ContentText Link = new Client.RichTBox.ContentText(ProtocolIrc.decode_text(text), SBAB, Configuration.CurrentSkin.mrcl[color]);
                        return Link;
                    }

                    if (!closed)
                    {
                        if (!int.TryParse(text[position + 1].ToString() + text[position + 2].ToString(), out color))
                        {
                            if (!int.TryParse(text[position + 1].ToString(), out color))
                            {
                                color = 0;
                            }
                        }
                        if (color > 9)
                        {
                            text = text.Remove(position, 3);
                        }
                        else
                        {
                            text = text.Remove(position, 2);
                        }
                        closed = true;
                        if (color < 16)
                        {
                            text = text.Substring(position);
                            break;
                        }
                    }
                }
                position++;
            }
        }
        return null;
    }

You'd have to post (an outline of) the rest of the code. But yes, most likely you're doing double work here. — Henk Holterman
– Henk Holterman, Commented Apr 19, 2013 at 9:02
"So, is it a good idea to attempt such an optimizations?" Almost certainly not! This must be one of the most-used functions in the library. It has gotten a lot of attention. Hard to imagine you could improve on it except for very special cases and by really dedicated specialists. — Thilo
– Thilo, Commented Apr 19, 2013 at 9:06
Going through a string, matching patterns, changing strings... maybe you also want to time how a Regex performs. — Corak
– Corak, Commented Apr 19, 2013 at 9:10
You also may want to replace your code that finds a position with IndexOf method of string. like position = text.IndexOf(colorchar); and then position = text.IndexOf(colorchar, position); — Andrei Zubov
– Andrei Zubov, Commented Apr 19, 2013 at 9:13

Vegard Innerdal · Accepted Answer · 2013-04-19 09:58:52Z

1

Short answer is that your optimization is no optimization at all.
Basically, String.Contains(...) just returns String.IndexOf(..) >= 0
You could improve your alogrithm to:

int position = text.IndexOf(colorchar.ToString()...);
if (-1 < position)
{  /* Do it */ }

edited Apr 19, 2013 at 9:58

answered Apr 19, 2013 at 9:30

Vegard Innerdal

3472 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

AK_ · Accepted Answer · 2013-04-19 09:15:09Z

0

Yes.

And doesn't have a bug (ahhm...).

There are better ways of looking for multiple substrings in very long texts, but for most common usages String.Contains (or IndexOf) is the best.

Also IIRC the source of String.Contains is available in the .Net shared sources

Oh, and if you want a performance comparison you can just measure for your exact use-case

answered Apr 19, 2013 at 9:15

AK_

8,1397 gold badges51 silver badges81 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:43:18Z

0

Check this similar post How does string.contains work

I think that you will not be able to simply do anything faster than String.Contains, unless you want to use standard CRT function wcsstr, available in msvcrt.dll, which is not so easy

edited May 23, 2017 at 11:43

CommunityBot

11 silver badge

answered Apr 19, 2013 at 9:15

Hassan Mokdad

5,90218 gold badges58 silver badges90 bronze badges

Comments

Daniel A.A. Pelsmaeker · Accepted Answer · 2013-04-19 09:38:52Z

Unless you have profiled your application and determined that the line with String.Contains is a bottle-neck, you should not do any such premature optimizations. It is way more important to keep your code's intention clear.

Ans while there are many ways to implement the methods in the .NET base classes, you should assume the default implementations are optimal enough for most people's use cases. For example, any (future) implementation of .NET might use the x86-specific instructions for string comparisons. That would then always be faster than what you can do in C#.

If you really want to be sure whether your custom string comparison code is faster than String.Contains, you need to measure them both using many iterations, each with a different string. For example using the Stopwatch class to measure the time.

Vlad · Accepted Answer · 2014-01-23 14:04:12Z

0

If you now the details which you can use for optimizations (not just simple contains check) sure you can make your method faster than string.Contains, otherwise - not.

answered Jan 23, 2014 at 14:04

Vlad

3,2012 gold badges27 silver badges57 bronze badges

Collectives™ on Stack Overflow

is String.Contains() faster than walking through whole array of char in string?

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related