200

// this e works
document.getElementById("p").oncontextmenu = function(e) {
  e = e || window.event;
  var target = e.target || e.srcElement;
  console.log(target);
};

// this e is undefined
function doSomething(e) {
  e = e || window.event;
  var target = e.target || e.srcElement;
  console.log(target);
}
<p id="p" onclick="doSomething(e)">
  <a href="#">foo</a>
  <span>bar</span>
</p>

There are some similar questions have been asked.

But in my code, I'm trying to get child elements who's been clicked, like a or span.

So what is the correct way to pass event as an argument to event handler, or how to get event inside handler without passing an argument?

edit

I'm aware of addEventListener and jQuery, please provide a solution for passing event to inline event hander.

4
  • developer.mozilla.org/en/docs/DOM/EventTarget.addEventListener Commented May 6, 2013 at 17:54
  • 5
    Is there a good reason for using inline event handlers rather than switching to addEventListener? en.wikipedia.org/wiki/Unobtrusive_JavaScript Commented May 6, 2013 at 17:56
  • 6
    @Xotic750 For me yes, no need to care about re-binding them manually everytime when dynamically loading or reloading html through ajax for example. Commented Aug 31, 2019 at 20:07
  • 2
    Inline handlers are more declarative Commented Aug 14, 2021 at 16:24

5 Answers 5

314

to pass the event object:

<p id="p" onclick="doSomething(event)">

to get the clicked child element (should be used with event parameter:

function doSomething(e) {
    e = e || window.event;
    var target = e.target || e.srcElement;
    console.log(target);
}

to pass the element itself (DOMElement):

<p id="p" onclick="doThing(this)">

see live example on jsFiddle.

You can specify the name of the event as above, but alternatively your handler can access the event parameter as described here: "When the event handler is specified as an HTML attribute, the specified code is wrapped into a function with the following parameters". There's much more additional documentation at the link.

Sign up to request clarification or add additional context in comments.

10 Comments

(And for anyone wondering: Yes, this does work on Chrome, Firefox, etc., even though some [Firefox, for instance] don't have a global event object. It's because the context in which the DOM0 handler is called has an event object, even if [on some browsers] it isn't a global.)
Passing ´event´ is the only way that I know, provided it is supported. Parsing ´this´ is of no use in this situation
@user1643156 That's very important. the parameter must be named exactly as "event"
Wadih M.'s answer is way better than this. This one is misleading (like others similar to it), making people believe that "(event)" parameter should be put into the function call, when, actually, JavaScript has the "event" parameter already and readily available inside the called function, so there is no need to declare it (it took me days to realise that it made no difference changing the variable name, because it was not really being passed). Also, the explanation given there dismisses any doubts about why JS works like that (maybe it shouldn't, but that's not on me to judge...)
The reason the 'event' object can be used as an argument to the in-HTML inline event-handler is explained in developer.mozilla.org/en-US/docs/Web/Guide/Events/… .
|
39

You don't need to pass this, there already is the event object passed by default automatically, which contains event.target which has the object it's coming from. You can lighten your syntax:

This:

<p onclick="doSomething()">

Will work with this:

function doSomething(){
  console.log(event);
  console.log(event.target);
}

You don't need to instantiate the event object, it's already there. Try it out. And event.target will contain the entire object calling it, which you were referencing as "this" before.

Now if you dynamically trigger doSomething() from somewhere in your code, you will notice that event is undefined. This is because it wasn't triggered from an event of clicking. So if you still want to artificially trigger the event, simply use dispatchEvent:

document.getElementById('element').dispatchEvent(new CustomEvent("click", {'bubbles': true}));

Then doSomething() will see event and event.target as per usual!

No need to pass this everywhere, and you can keep your function signatures free from wiring information and simplify things.

Update 2022-10-30:

I have contacted someone from WHATWG, and another way it could be done is below, although some IDE's report it as "obsolete" which it's not. You could pass the "event" keyword (no capital E) in your caller's argument list, in any position, and use it as such.

Below would work, a, b, c and d being extra arguments to pass if any, to demonstrate the order doesn't matter:

<p onclick="doSomething(a,b,event,c,d)">

And in your function definition, you would capture it accordingly:

function doSomething(arg1, arg2, arg3, arg4, arg5){} //arg3 would contain the event

And access the usual properties, in this case since we wired event with arg3:

console.log(arg3.target)

13 Comments

At least on IE11, this is not true, There are no default arguments.
@cskwg It does work for IE11 as well. It works on all major browsers as this is necessary for backwards compatibility. As I mentioned in the answer, only if the javascript function is fired from an event, which is the only scenario where an event exists, there will be an object already called "event" that you can readily access inside your function without having had to pass extra wiring to your function prototype. I just did a test on my machine with IE11 for an onclick event and and the 'event' variable contained a "PointerEvent object".
I couldn't simulate a click on a radio button, am I missing something? document.getElementById("radioOption1").click() works but this did not: document.getElementById("radioOption1").dispatchEvent(new CustomEvent("click", {'bubbles': true}))
It's best not to use this method for referencing the event as it is deprecated. developer.mozilla.org/en-US/docs/Web/API/Window/event
@FarzadSoltani Right. I just posted my complaint to that MDN article: github.com/mdn/content/issues/21848 . I really don't see why this should be removed. I'm going to keep using it, since I build all my sites from scratch, I've never had an issue with it.
|
25

Since inline events are executed as functions you can simply use arguments.

<p id="p" onclick="doSomething.apply(this, arguments)">

and

function doSomething(e) {
  if (!e) e = window.event;
  // 'e' is the event.
  // 'this' is the P element
}

The 'event' that is mentioned in the accepted answer is actually the name of the argument passed to the function. It has nothing to do with the global event.

3 Comments

Good tip. When people will start adopting web components call() and apply() will prove essential in emulating data binding capabilities available in mainstream js frameworks. One extra trick is to do something similar to Object.assign(this.querySelector('my-btn'), this) inside a web component and voila, data binding. You can access any method of the parent web component class from the inline events onclick="toggleBtnActive.call(this, true)".
This is the absolute only way i was able to get an asp radgrid to pass the click event to an event handler along with the row index.
@JohnLord Never heard of asp radgrid, however the natural javascript standards have always worked the same, and I never needed to use above confusing constructs to access my event and event.target objects.
2

Here is how I would do it to prevent users from copying and pasting invalid characters into input text fields:

function validatePaste(el, e) {
  var regex = /^[a-z .'-]+$/gi;
  var key = e.clipboardData.getData('text')
  if (!regex.test(key)) {
    e.preventDefault();
    return false;
  }
}

This function is located inside <script> tags and it is called like:

<input type="text" onpaste="validatePaste(event)">

1 Comment

while your example is good, your initial description came across like you were answering a completely different question.
-1

This would answer the question perfectly without having to worry about deprecation issues.

function doSomething(e){
  // instead of e.target, use just 'e'
  console.log(e)
}

<p id="p" onclick="doSomething(this)">
   <a href="#">foo</a>
   <span>bar</span>
</p>

1 Comment

That’s not the same. Here e will be the <p> element, not the event, so there is no way to do e.preventDefault() for instance.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.