How to build a string with the value of a variable embedded?

Question

HI, I've got:

<script language="javascript" type="text/javascript">
$(document).ready(function() {
 $("#thumbs a").click( function() {
      var BGswitch = $(this).attr("href");
      $("#target").css("background-image", "url(BGswitch)");
      return false;
      });
});
</script>

And it's not quite working--when I look at the code, the variable itself (BGswitch) is being put in the background-image slot instead of the value of the variable which is supposed to be the href.... Anyone? Some kind of syntax error or something?

THANK YOU!

Shadi Almosri · Accepted Answer · 2009-10-29 04:54:07Z

1

$("#target").attr("background-image", "url(" + BGswitch + ")");

Check this

answered Oct 29, 2009 at 4:54

Shadi Almosri

12k16 gold badges62 silver badges80 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

deceze · Accepted Answer · 2009-10-29 04:52:23Z

1

"url(BGswitch)" is literally the string "url(BGswitch)". You need to build the string by concatenation:

"url(" + BGswitch + ")"

answered Oct 29, 2009 at 4:52

deceze♦

525k89 gold badges807 silver badges954 bronze badges

Comments

Sergej Andrejev · Accepted Answer · 2009-10-29 04:52:32Z

1

Shouldn't it be

$("#target").css("background-image", "url("+BGswitch+")");

answered Oct 29, 2009 at 4:52

Sergej Andrejev

9,47311 gold badges75 silver badges109 bronze badges

Collectives™ on Stack Overflow

How to build a string with the value of a variable embedded?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related