Update query sqlite - Android

Question

I'm not able to crack a simple Update query in SQLite in my android app.. here is the query,

int fav = 1;
Cursor c = sqliteDB.rawQuery("UPDATE "+ MyConstants.TABLE_NAME + " SET "+MyConstants.TABLE_NAME+"."+MyConstants.ISFAV+ " = "+fav+ " WHERE " +MyConstants.TABLE_NAME+"."+MyConstants.WORD_NAME+ " = \""+word_name+"\"", null);

Here is the exception,

07-06 23:41:48.723: E/AndroidRuntime(1102): FATAL EXCEPTION: main
07-06 23:41:48.723: E/AndroidRuntime(1102): android.database.sqlite.SQLiteException: near ".": syntax error (code 1): , while compiling: UPDATE words SET words.isfavor = 1 WHERE words.word = "hello"
07-06 23:41:48.723: E/AndroidRuntime(1102):     at android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method)
07-06 23:41:48.723: E/AndroidRuntime(1102):     at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:1013)
07-06 23:41:48.723: E/AndroidRuntime(1102):     at android.database.sqlite.SQLiteConnection.prepare(SQLiteConnection.java:624)
07-06 23:41:48.723: E/AndroidRuntime(1102):     at android.database.sqlite.SQLiteSession.prepare(SQLiteSession.java:588)
07-06 23:41:48.723: E/AndroidRuntime(1102):     at android.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:58)
07-06 23:41:48.723: E/AndroidRuntime(1102):     at android.database.sqlite.SQLiteQuery.<init>(SQLiteQuery.java:37)
07-06 23:41:48.723: E/AndroidRuntime(1102):     at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:44)

HalR · Accepted Answer · 2013-07-06 19:34:11Z

5

You keep using the table name inappropriately. It should be more like this:

int fav = 1;
Cursor c = sqliteDB.rawQuery("UPDATE "+ MyConstants.TABLE_NAME + " SET "+ MyConstants.ISFAV + " = "+fav+ " WHERE " + MyConstants.WORD_NAME + " = \""+word_name+"\"", null);

which should give you a resultant query that looks more like this:

UPDATE words SET isfavor = 1 WHERE word = "hello"

answered Jul 6, 2013 at 19:34

HalR

11.1k5 gold badges51 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

CL. · Accepted Answer · 2013-07-06 19:33:00Z

2

UPDATE statements always have only one table, so prefixing column names with table names would be meaningless and is not allowed.
In SQL, strings are delimited with '. " is used for identifiers like column names; your query will blow up when you try to handle the word word.
To avoid string formatting problems, you should use parameters:

    sqliteDB.rawQuery("UPDATE ... WHERE word = ?",
                      new String[] { word_name });

answered Jul 6, 2013 at 19:33

CL.

182k18 gold badges241 silver badges282 bronze badges

Collectives™ on Stack Overflow

Update query sqlite - Android

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related