PHP showing else "error" when not called

Question

I'm having a problem with my php code.

I don't want the else echo "Check it again!"; to show unless they input some data into the form(input box) and it's not valid. But when I load the page it shows the error above the box.

<?PHP
if (filter_var($email, FILTER_VALIDATE_EMAIL)) {
    mysql_query("INSERT INTO newsletter (email) VALUES('$email')") or die(mysql_error());
        echo 'You have registered your E-Mail address to our database! You will now receive regular updates on the progess!';
    }else{
        echo "Check it again!";
}
?>

<form name="newsletter" method="post" action="<?PHP $_SERVER['PHP_SELF']?>">
<input type="text" name="newsletter" id="newsletter">
<input type="submit" value="SUBMIT!">
</form>

include('./_inc/config.php'); $email = $_POST['newsletter']; $email = stripslashes($email); — user2562492
– user2562492, Commented Jul 8, 2013 at 23:05
Do a check for if a post field is set first. This is basic PHP and you will get a few million results from a google search... if( isset($_POST['newsletter']) ) — Joel Murphy
– Joel Murphy, Commented Jul 8, 2013 at 23:06

Fallen · Accepted Answer · 2013-07-08 23:06:02Z

Try this :)

<?PHP
if($_SERVER["REQUEST_METHOD"]=="POST"){
    if (filter_var($email, FILTER_VALIDATE_EMAIL)) {
        mysql_query("INSERT INTO newsletter (email) VALUES('$email')") or die(mysql_error());
            echo 'You have registered your E-Mail address to our database! You will now receive regular updates on the progess!';
        }else{
            echo "Check it again!";
    }
}
?>

instead of

<?PHP

 if (filter_var($email, FILTER_VALIDATE_EMAIL)) {
    mysql_query("INSERT INTO newsletter (email) VALUES('$email')") or die(mysql_error());
    echo 'You have registered your E-Mail address to our database! You will now receive regular updates on the progess!';
    }else{
      echo "Check it again!";
    }
}

?>

Logic behind the edit: We'll check for the email or print "Check it again!" only if the form is submitted. Now if we don't check whether the form is submitted or this is the first time loading (or simple refresh) of the page, either insertion or the error display will occur. And we don't want that :)

Francisco Presencia · Accepted Answer · 2013-07-08 23:25:09Z

0

This is just an alternative to @MuhammedHedayet answer in the style I prefer, checking it only when you need to. Both should work perfectly:

<?PHP
if (filter_var($email, FILTER_VALIDATE_EMAIL)) {
    mysql_query("INSERT INTO newsletter (email) VALUES('$email')") or die(mysql_error());
        echo 'You have registered your E-Mail address to our database! You will now receive regular updates on the progess!';
    } else if ($_SERVER["REQUEST_METHOD"]=="POST"){
        echo "Check it again!";
}
?>

<form name="newsletter" method="post" action="<?PHP $_SERVER['PHP_SELF']?>">
<input type="text" name="newsletter" id="newsletter">
<input type="submit" value="SUBMIT!">
</form>

answered Jul 8, 2013 at 23:25

Francisco Presencia

8,8857 gold badges50 silver badges96 bronze badges

Collectives™ on Stack Overflow

PHP showing else "error" when not called

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related