Recursion not working in python

Question

I am trying to print a series in python which actually like Fibonacci but instead of adding you have to multiply.

My code is :

def robLan(n):
    if n > 3:
        robLan(n -1) * robLan(n - 2)

    elif n == 1:
        return 1

    elif n == 2:
        return 2

    elif n == 3:
        return 2

list = []
for i in range(1,10):
    z =  robLan(i)
    list.append(z)
print list

These are the error I get:

File "C:\Users\Arjun's\Documents\Aptana Studio 3 Workspace\List\com\__init__.py", line 16, in <module>
    z =  robLan(i)
  File "C:\Users\Arjun's\Documents\Aptana Studio 3 Workspace\List\com\__init__.py", line 3, in robLan
    robLan(n -1) * robLan(n - 2)
TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'

What is wrong here?

You're missing return in the first if block.

falsetru
– falsetru

2013-09-07 12:32:58 +00:00
Commented Sep 7, 2013 at 12:32 — falsetru
– falsetru, Commented Sep 7, 2013 at 12:32

Martijn Pieters · Accepted Answer · 2013-09-08 06:28:07Z

5

Your function doesn't return the recursive call:

if n > 3:
    robLan(n -1) * robLan(n - 2)

Without a return statement here, your function ends without an explicit return and None is returned instead:

>>> robLan(4) is None
True

The above should have returned 4 (roblan(3) * roblan(2) gives 2 * 2 is 4). For any starting value of 5 or over the function uses more than one level of recursion and a None return value ends up being used for multiplication.

Add return:

if n > 3:
    return robLan(n - 1) * robLan(n - 2)

Your statements can be simplified:

def robLan(n):
    if n > 2:
        return robLan(n - 1) * robLan(n - 2)
    return n

Your sample loop then generates:

[1, 2, 2, 4, 8, 32, 256, 8192, 2097152]

edited Sep 8, 2013 at 6:28

answered Sep 7, 2013 at 12:32

Martijn Pieters

1.1m326 gold badges4.2k silver badges3.4k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JeremyWang · Accepted Answer · 2013-09-07 12:47:41Z

1

you should return a value when n > 3

answered Sep 7, 2013 at 12:47

JeremyWang

313 bronze badges

Comments

Serjik · Accepted Answer · 2013-09-07 17:53:57Z

0

This is complete corrected code:

def robLan(n):
    if n > 3:
        return robLan(n -1) * robLan(n - 2)

    elif n == 1:
        return 1

    elif n == 2:
        return 2

    elif n == 3:
        return 2

list = []
for i in range(1,10):
    z =  robLan(i)
    list.append(z)
print list

answered Sep 7, 2013 at 17:53

Serjik

11.1k8 gold badges63 silver badges72 bronze badges

Collectives™ on Stack Overflow

Recursion not working in python

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related