jquery click function in for loop only working in last loop [closed]

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.

Closed 11 years ago.

This question appears to be off-topic because it lacks sufficient information to diagnose the problem. Describe your problem in more detail or include a minimal example in the question itself.
Questions concerning problems with code you've written must describe the specific problem — and include valid code to reproduce it — in the question itself. See SSCCE.org for guidance.

I'm probably doing something obviously wrong, but I just can't see it. I'm trying to use a for loop to define multiple click events and am experiencing an unexpected result. Some of this is working (the hide and show at the beginning of the function, but both sections wind up targeting the second item in the loop. Could somebody take a look at this and tell me what I'm doing wrong? Thank you so much for your help!

here is the link: http://grana.us/test/expand2.html

Questions concerning problems with code you've written must describe the specific problem — and include valid code to reproduce it — in the question itself. — user1864610
– user1864610, Commented Oct 26, 2013 at 12:06
@FlashThunder That's not the point. If the OP removes the page at the link the question and the answers become meaningless. Stack Overflow is intended to become an archive of useful questions and answers that can be used in the future. — user1864610
– user1864610, Commented Oct 26, 2013 at 12:16

Flash Thunder · Accepted Answer · 2013-10-26 12:07:55Z

1

You are assigning same event to all summaries for every id. This is wrong...

First... to hide all details and show all toglers simply use:

$('.details').hide();
$('.toggler').show();

And then define click function to all sumaries:

$('.summary').click(function(){
   if($('.toggler',this).html() == ' -'){
      $('.toggler',this).html(' +');
      $('.details',$(this).parent()).hide();
   }else{
      $('.toggler',this).html(' -');
      $('.details',$(this).parent()).show();
   }
});

Put everything in...

$(function(){
   ...
});

and should be ok.

answered Oct 26, 2013 at 12:07

Flash Thunder

12.1k10 gold badges55 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

jquery click function in for loop only working in last loop [closed]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related