javascript combining multiple regex

Question

I'm using a series of regex and jquery functions to format a textbox of 9 digits. The code looks like this:

function FormatBox() {

    var TheText = $('#TheBox').val();

    //remove leading 0
    if (TheText.charAt(0) === '0') {
       TheText = TheText.substring(1);   
    }

    //take only digits
    TheText = TheText.replace(/\D/g, ''); 

    //take only the first 9 digits
    if (TheText.length > 9) {
        TheText = TheText.substring(0, 9);
    }

    //reformat string
    TheText = TheText.replace(/(\d{1})?(\d{2})?(\d{2})?(\d{2})?(\d{2})?/, '$1 $2 $3 $4 $5');

    //trim string
    TheText = $.trim(TheText);

    $('#TheBox').val(TheText);
}

function Start() {

    $('#TheBox').keyup(FormatBox);
}

$(Start);

As it is, it all works fine but I'm looking to combine these rules that mix regex and jquery into one regex but I'm struggling to get it working. What do I need to do to add the constraints to the reformatted string to make is work? The jsFiddle is here.

Thanks.

You could use this in FormatBox instead of grabbing #TheBox again. Also why is everything written with LeadingCase? This is usually a convention for naming constructors. — elclanrs
– elclanrs, Commented Dec 3, 2013 at 21:34

Casimir et Hippolyte · Accepted Answer · 2013-12-03 21:32:28Z

2

Try this:

TheText = TheText.replace(/(\d{1,2})(?=(?:\d{2})+$)/g, '$1 ');

answered Dec 3, 2013 at 21:32

Casimir et Hippolyte

90k5 gold badges102 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

frenchie Over a year ago

Ok, good start but it doesn't add the spaces at the right place and doesn't validate the length. Almost there, upvoted!

kalley · Accepted Answer · 2013-12-03 21:55:28Z

1

This doesn't put it all into 1 regex, but it does simplify it a bit:

$(Start);

function Start() {

    var box = $('#TheBox').keyup(FormatBox);

    function FormatBox() {

        box.val($.trim(box.val()
                       .replace(/(^0+|\D)/g, '') // gets rid of all leading zeros (in case of paste) and any non-numbers
                       .substring(0, 9) // or .replace(/^(.{0,9}).*/, '$1')
                       .replace(/(\d)?(\d{2})?(\d{2})?(\d{2})?(\d{2})?/, '$1 $2 $3 $4 $5'))
               );
    }
}

edited Dec 3, 2013 at 21:55

answered Dec 3, 2013 at 21:38

kalley

18.5k2 gold badges41 silver badges37 bronze badges

2 Comments

Scott Sauyet Over a year ago

Possibly the following between your replace clauses instead of the final substring: replace(/^(.{0,9}).*/, '$1'). It makes little practical difference, but seems clearer to me rather than the magic number of 13.

kalley Over a year ago

@ScottSauyet good point. I'm not sure why I felt I needed the substring at the end

Collectives™ on Stack Overflow

javascript combining multiple regex

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related