Adding a prefix "#" to certain string values in an array

Question

What I'm trying to do is add a check to my for loop that searches for "value_1" or "value_3". If found, than add a "#" at the beginning of that value.

Ex: #value_1, value_2, #value_3, etc

Here's my code:

for(i=1; i < columns.length-1; i++){
    currentRecordKey = columns[i].dataIndex;
    if(currentRecordKey == "value_1" || "value_3") {
        currentRecordKey = "#" + currentRecordKey;
    }
}

Worked out in my head, but this doesn't get the job done.

Any ideas?

Cheers

What seems to be the issue? You haven't explained where your code goes wrong or what you're trying to fix. — Jasper
– Jasper, Commented Dec 12, 2013 at 20:18
Sorry My post was riddled with typos haha. But the -1 is necessary for the grid that I have set up — Clay Banks
– Clay Banks, Commented Dec 12, 2013 at 20:22

JCOC611 · Accepted Answer · 2013-12-12 20:18:54Z

4

It should be

for(i=1; i < columns.length-1; i++){
    //icon record
    var currentRecordKey = columns[i].dataIndex;
    if(currentRecordKey == "value_1" || currentRecordKey == "value_3") {
         currentRecordKey = "+" + currentRecordKey ;
    }
    columns[i].dataIndex = currentRecordKey;
}

Your error is that if you don't restate that you are checking for currentRecordKey == "value_3", JavaScript will only check if currentRecordKey is true, and any non-empty string is.

Also, I've commented out icon record which might also be a typo.

Edit: also fixed the issue explained by Jasper and made currentRecordKey a local variable.

answered Dec 12, 2013 at 20:18

JCOC611

19.8k15 gold badges72 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jasper Over a year ago

If you want to alter the data in the columns array then this won't do it, it's still saving the "updated" string in a separate variable which will be overwritten each iteration of the loop. But if you're looking to do work with that new variable within the loop, you should be good to go.

JCOC611 Over a year ago

@Jasper: fixed the issue

Jasper Over a year ago

Oh, no fix really needed I think. The OP hasn't stated what they're really after, nice answer though.

Collectives™ on Stack Overflow

Adding a prefix "#" to certain string values in an array

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related