How optimize some code by making array?

Question

in my code i have a for that it repeat 100 time for {lg0 , lg1 , samsong0 ,...}
{lg0 , lg1 , samsong0 ,...} is list of some class that they have static List

for (int i = 0;i < lg0.brandStringList.length ; i++ )
{
    MobileInformation mobile = new MobileInformation();

    mobile.Alert_types = lg0.Alert_typesStringList[i];
    .
    .
    .
    mobile.Video = lg0.VideoStringList[i];          
}

one way for Solving problem is writting 100 for that is not good way.
for ex:
if i have {lg0 , lg1} i must write below code

for (int i = 0;i < lg0.brandStringList.length ; i++ )
{
    MobileInformation mobile = new MobileInformation();

    mobile.Alert_types = lg0.Alert_typesStringList[i];
    .
    .
    .
    mobile.Video = lg0.VideoStringList[i];          
}

for (int i = 0;i < lg1.brandStringList.length ; i++ )
{
    MobileInformation mobile = new MobileInformation();

    mobile.Alert_types = lg1.Alert_typesStringList[i];
    .
    .
    .
    mobile.Video = lg1.VideoStringList[i];          
}

Question
How i can make a List for all Class and optimize above code by using it.

so you have 100 classes that all define the same properties (brandStringList , Alert_typesStringList, VideoStringList...)? — njzk2
– njzk2, Commented Mar 3, 2014 at 15:15
I understand why you would want to change that design. Can you put all values in only one class? From the code posted, I don't understand the need to separate lg1, lg0 ... — njzk2
– njzk2, Commented Mar 3, 2014 at 15:18
My data is big that exist in all class . so if i put them in one class size of file will be big. So i get error limited size file eclipse. — Mahdi-bagvand
– Mahdi-bagvand, Commented Mar 3, 2014 at 15:21

Larry Schiefer · Accepted Answer · 2014-03-03 15:30:04Z

1

Define a base class or interface which exposes the common methods/fields you need, then make a list of the base class and iterate through the components within the class:

public class BaseInfoClass {
    public static brandStringList[];
    public static Alert_typesStringList[];
    public static VideoStringList[];
}

private LinkedList<BaseInfoClass> mAllInfo;  //  Init this as you need with lg0, etc.

public void whateverMethod() {
    for (BaseInfoClass curClass : mAllInfo) {
        for (int i = 0; i < curClass.brandStringList.length; i)) {
            MobileInformation newInfo = new MobileInformation();
            mobile.Alert_types = curClass.Alert_typesStringList[i];
            .
            .
            .
            mobile.Video = curClass.VideoStringList[i];          
        }
    }
}

answered Mar 3, 2014 at 15:30

Larry Schiefer

15.8k2 gold badges31 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How optimize some code by making array?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related