Error stream blocking when running external command with Java

Question

Working on SEAndroid, I call Setools commands from my Java application. It works perfectly with small SEAndroid policy and now I need to test my tool with real SEAndroid policy. But unfortunately, I face a problem with an error stream.

Here my code I used to call external commands :

public static BufferedReader runCommand(final String[] args)
            throws IOException {

    BufferedReader stdInput = null;
    BufferedReader stdError = null;
    try {
        Process p = Runtime.getRuntime().exec(args);

        stdInput = new BufferedReader(new
                InputStreamReader(p.getInputStream()));

        stdError = new BufferedReader(new
                InputStreamReader(p.getErrorStream()));

        // read any errors from the attempted command
        String s = null;
        StringBuilder err = new StringBuilder();

        while ((s = stdError.readLine()) != null) {
            err.append(s + "\n");
        }
        if (err.length() != 0) {
            throw new IOException(err.toString());
        }

        return stdInput;
    } finally {
        if (stdError != null) {
            stdError.close();
        }
    }
}

So, as you can see, I call an external command. Then read the error stream and throw an exception if there is any errors, otherwise I return the InputStream, so I can parse it later.

With a real SEAndroid policy, the error stream seems to block (even if I read a single char) and I can't parse the result of the command. If I close the error stream without reading anything, the application works fine, but I want to handle errors if any. If I type the command in a console, it works fine too.

In the first case (with small SEAndroid policy), the output of the command is small ( ~350 lines). In the second case (with a real SEAndroid policy), the output of the command is larger ( >1500 lines).

Is it possible that the size of the output stream influences the error stream? The two streams are two distinctive resources, isn't it? The fact that I do not read the output stream immediately have an importance?

I fear that its not a "programming" problem but more a system problem...

Any suggestion?

Thanks in advance for your help=)

Edit:

I try to read the output stream before the error stream and it works. But I need to check the error stream before perform any parsing on the output stream, so the problem is still topical.

Jeremy · Accepted Answer · 2014-04-23 18:55:36Z

1

First, it's probably better to use the newer ProcessBuilder class as opposed to Runtime exec. If you want to go a step further, you can even use Apache commons-exec which takes care of stream handling and other things for you.

Next, as you've discovered, process control is a tricky thing in Java and you've run into one of its tricky issues. From the documentation for java's Process class:

The parent process uses these streams to feed input to and get output from the subprocess. Because some native platforms only provide limited buffer size for standard input and output streams, failure to promptly write the input stream or read the output stream of the subprocess may cause the subprocess to block, and even deadlock.

You need to have something consuming both (Error and Output) streams or you risk deadlock - these should each be read on their own threads. Using something like a StreamGobbler (google it, there are plenty out there) would be a good step, or you can roll your own if you're so inclined. It isn't too hard to get it right but if you're unfamiliar with multithreading you may want to look at someone else's implementation or go the Apache commons-exec route.

answered Apr 23, 2014 at 18:55

Jeremy

1802 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Zangdak Over a year ago

Thanks. I use a processBuilder with a StreamGobbler and it works. I don't even need to change anything else in my application. I used the code I found here. Do you have any good implementation of StreamGobbler to suggest?

Jeremy Over a year ago

I believe when I was struggling with this same issue I used the same code for my template. I changed it a bit to suit my needs, but the underlying structure was the same.

Zangdak Over a year ago

The StreamGobbler from the link I give is not very optimized. Indeed, it performs two copies of the stream's content... Not very effective with huge stream.

Felix Leipold · Accepted Answer · 2014-11-26 15:57:52Z

0

The processing of output is so annoying, that I wrote little library called jproc that deals with the problem of consuming stdout and stderr. It can simply filter strings through external programs likes this:

ProcBuilder.filter("x y z","sed" ,"s/y/a/")

It also lets you specify a timeout for the completion and will convert non-zero exit codes into exception.

answered Nov 26, 2014 at 15:57

Felix Leipold

1,11310 silver badges17 bronze badges

Collectives™ on Stack Overflow

Error stream blocking when running external command with Java

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related