Xcode error: Comparison between pointer and integer? [duplicate]

Question

I am getting this error on my if statement.

CODE:

-(IBAction)login:(id)sender
{

    NSString *correctUser = @"money";
    NSString *correctPassword = @"ilovemoney";

    if ((usernameTextField.text == correctUser)==YES && (passwordTextField.text = correctPassword)==YES) //error is on the beginning of this if statement.
    {
        [self performSegueWithIdentifier:@"oneTransition" sender:sender];
    }

}

What are the types of usernameTextField.text and YES?

Samuel Edwin Ward
– Samuel Edwin Ward

2014-05-24 16:58:49 +00:00
Commented May 24, 2014 at 16:58 — Samuel Edwin Ward
– Samuel Edwin Ward, Commented May 24, 2014 at 16:58

Jesse Rusak · Accepted Answer · 2014-05-24 16:35:24Z

4

There are a bunch of problems here.

You're using = instead of == in your second test, which is assignment, not comparison; this is why you're getting the warning.
Comparing strings with == doesn't do what you want. You should use [usernameTextField.text isEqual:correctUser], for example.
You should never compare something to YES as in == YES. So, instead of if (something == YES) just say if (something).

answered May 24, 2014 at 16:35

Jesse Rusak

57.3k12 gold badges103 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Dave Over a year ago

On that third point, you should always use if( ((((a == b) == YES) == YES) == YES) == YES ). It's the only way to be sure.

Jesse Rusak Over a year ago

Yes, thanks, @Dave, I had forgotten to mention that.

benr783 Over a year ago

Thanks. that worked, I used the isEqual.

Collectives™ on Stack Overflow

Xcode error: Comparison between pointer and integer? [duplicate]

1 Answer 1

3 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Linked

Related