Rails - Rspec error: no implicit conversion

Question

I'm testing a model that receives a optional parameter and Rspec is giving me an error:

no implicit conversion of Symbol into Integer

My route:

get "classification/teams(/:team_id)" => "classifications#teams"

My model:

class Classification
def self.teams(params = [])
    team_id = params[:team_id] unless params[:team_id].nil?
    ...

My test:

it 'returns the classification' do
    expect(Classification.teams).to be_true
end

My API is working well, but I need to implement some tests and I'm getting this error. If I change params[:team_id] for params['team_id'] the error occurs but with: no implicit conversion of String into Integer.

Dont want to bother you, but its part of conventions to write code in english. Up to you though — apneadiving
– apneadiving, Commented Jun 4, 2014 at 12:49
@SérgioToledo - You wrote My model: - is it active record model? How do you use teams method in your controller? — BroiSatse
– BroiSatse, Commented Jun 4, 2014 at 12:52

Patrick Oscity · Accepted Answer · 2014-06-04 12:58:28Z

3

Your problem lies in a default value for params, it should be hash, not an array:

def self.teams(params = {})

edited Jun 4, 2014 at 12:58

Patrick Oscity

54.9k19 gold badges149 silver badges173 bronze badges

answered Jun 4, 2014 at 12:40

BroiSatse

44.8k8 gold badges63 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Seralto Over a year ago

in fact we got some progress. the test above is passing with your tip (tanks @BroiSatse), but I still got the same error when I pass a parameter: expect(Classification.teams 1).to be_true

BroiSatse Over a year ago

@SérgioToledo - You need to decide what you want to pass to this method. Your test is passing an integer, while you set your default value to be an array (or hash). Are you using params only to get team_id value? (BTW, you know you have no access to params in your model without interacting with controller, right?)

BroiSatse Over a year ago

@SérgioToledo - According to your comment under the question, you need to change your test to expect(Classification.teams(team_id: 1)).to be_true. When you done please post both your model and controller to codereview.stackexchange.com, as it seems that your code tries to break out of MVC pattern.

Seralto Over a year ago

Dear @BroiSatse, you're the guy! All issues are solved. Thank you for your help and regards.

Collectives™ on Stack Overflow

Rails - Rspec error: no implicit conversion

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related