Rails: Controller redirect vs Javascript redirect

Question

Currently I'm working on a project which performs some client side validation (using Javascript) on a form when submitted and then based on an Ajax request, either makes a window.location.href redirect or submits the form to be handled by the controller.

My question, what is the best way to handle this situation? Should the form be directly submitted to the controller where the request will be processed or is the current method a better approach?

I feel the redirection based on the Ajax call is completely unnecessary since the controller can do this anyway.

I don't understand quite well the situation, when does the ajax request make a redirection? I guess when validations fail, but can you confirm it? — Ivan Fraixedes
– Ivan Fraixedes, Commented Aug 26, 2014 at 11:06
Yes that is correct. It can be confirmed in the success event handler, which is where it's redirected. — KcC0
– KcC0, Commented Aug 26, 2014 at 11:34

Alain M. Lafon · Accepted Answer · 2014-08-26 11:12:30Z

1

Your gut feeling is right. window.location.href is also not a redirect in a HTTP sense (which would be a HTTP status code 302 for example), but a completely new request.

There's a couple of benefits as a side effect:

easily testable with unit tests
you can use the controller logic from different locations (also as an API)
DRY: no code duplication in controller (where you need the redirect anyway) and the javascript

answered Aug 26, 2014 at 11:12

Alain M. Lafon

1,7081 gold badge13 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

KcC0 Over a year ago

I figured it wasn't an actual redirect since the browser's history also gets messed up if the application's javascript is not completely loaded. If I try to return to the previous page after the redirect, it skips a page. But that's a different question all together.

KcC0 Over a year ago

Thanks for the answer though. I guess I'll just have to refactor a bit of code to handle the redirection through the controller directly. I'll accept your answer by the end of the day if no one else answers :)

Alain M. Lafon Over a year ago

Thanks a bunch. If you have a follow up question, you can add it here.

Alain M. Lafon Over a year ago

And good luck with the refactoring. Write a couple specs to guard against regression(;

Collectives™ on Stack Overflow

Rails: Controller redirect vs Javascript redirect

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related