How to properly use button toggle function

Question

button1Toggle() function doesn't seem to work. Text in the button doesn't change. Can't find the bug.

 function button1Toggle() {
    if (document.myform.button1.value == "Mute") {
         document.myform.button1.value = "Unmute";
      } else {
         document.myform.button1.value = "Mute";
      }
    }

<div>Tablet</div><br>
<form name ="myform">
    <input type="button" name="button1" id="button1" value="Mute" onclick="button1Toggle()">
</form>

write: document.getElementById('button1').value

Gul Muhammad Akbari
– Gul Muhammad Akbari

2014-11-02 06:00:28 +00:00
Commented Nov 2, 2014 at 6:00 — Gul Muhammad Akbari
– Gul Muhammad Akbari, Commented Nov 2, 2014 at 6:00
you code seems fine.. probably your code have another bug

Girish
– Girish

2014-11-02 06:02:23 +00:00
Commented Nov 2, 2014 at 6:02 — Girish
– Girish, Commented Nov 2, 2014 at 6:02
Your code is works, or maybe some browser issues?

Andi N. Dirgantara
– Andi N. Dirgantara

2014-11-02 06:07:32 +00:00
Commented Nov 2, 2014 at 6:07 — Andi N. Dirgantara
– Andi N. Dirgantara, Commented Nov 2, 2014 at 6:07
Maybe you have another button with the same id?

TamarG
– TamarG

2014-11-02 06:14:49 +00:00
Commented Nov 2, 2014 at 6:14 — TamarG
– TamarG, Commented Nov 2, 2014 at 6:14

TamarG · Accepted Answer · 2014-11-02 06:14:38Z

1

Maybe you have another button with the same id?

Try -

function button1Toggle(btn) {
    if (btn.value == "Mute") {
        btn.value = "Unmute";
    } else {
        btn.value = "Mute";
    }
}


 <div>Tablet</div><br>
     <form name ="myform">
        <input type="button" name="button1" id="button1" value="Mute" onclick="button1Toggle(this)">
    </form>

edited Nov 2, 2014 at 6:14

answered Nov 2, 2014 at 6:08

TamarG

3,58012 gold badges47 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jakob Jingleheimer Over a year ago

or more concisely: button1Toggle(btn) { btn.value = (btn.value === "mute")? "unmute" : "mute"; }

Collectives™ on Stack Overflow

How to properly use button toggle function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related