If statement and .click function

Question

I have been making a videogame with javascript. However, there is just one thing that I don't understand.

if (!user.hasOwnProperty('firstName')) {
    $('#inputSubmit').click(function () {
        user.firstName = getInput();
        addText_1("Good, now type your character's last name");
    });
};

this statement will keep executing. Basically the condition is that the user does't have a first name property and the function will add the first name on the click of submit. However, you can keep pressing the submit button and it will keep adding the text.

$('#inputSubmit').click(function() {
    if(!user.hasOwnProperty('firstName')) {
        user.firstName = getInput();
        addText_1('hello');
    };
});

However, this works. It only does it once. Could someone explain the principle that I am not understanding?

Thank you very much!

Where do you run the code in your first sample? Is it possible that the submit handler is added once and not removed after the user clicks submit? — tsnorri
– tsnorri, Commented Nov 29, 2014 at 16:09

beautifulcoder · Accepted Answer · 2014-11-29 16:09:30Z

2

You attach a click event to #inputSubmit. This callback ignores the surrounding if statement. In your second sample code, if is inside the callback function.

answered Nov 29, 2014 at 16:09

beautifulcoder

11.4k3 gold badges21 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

will smith Over a year ago

I guess it makes sense. I will accept your answer in 10 minutes. Thank you!

deitch Over a year ago

Also, as a general design principle, you are best assigning your handlers and then checking the logic inside them, which your second format does. If you will never handle clicks unless some certain app-wide or page-wide or global condition is true, then fine, but in this case you are saying, "if the user has not filled something in, don't do the click processing. That is better inside.

behnamizadi · Accepted Answer · 2014-11-29 16:15:47Z

0

in first code "hasOwnProperty" checked in outer scope of function() but in second code the condition checked in scope of function

answered Nov 29, 2014 at 16:15

behnamizadi

1531 gold badge2 silver badges8 bronze badges

Collectives™ on Stack Overflow

If statement and .click function

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related