jquery this pointer scope when call a function in ajax

Question

I want to call a external function from $.ajax when getting through a xml file, but I am confused by the scope of this pointer in this case.

so in my ajax function

function getCustomerInfo (customerID) {
    $.ajax ({
        type: "GET",
        url: "./content/customer_list.xml",
        dataType:"xml",
        success: function (xml) {
            $(xml).find("customer[value=" + customerID + "]").each(function(){

//I want to create a function and call here to achieve the following commented code
//the commented code works fine. I just want to change it to a function because 
//otherwise I have to hard code many similar lines...

// so here is the current function I call:
                addCustomerDetails("timeAdded", "time_added");

// the following code works fine:
                // var timeAdded = $(this).children('time_added').text();
                // var lastUpdate = $(this).children('last_update').text();
                // $("#time_added").html("<p>" + timeAdded + "</p>");
                // $("#last_update").html("<p>" + lastUpdate + "</p>");

            });
        }
    });
}

So the current addCustomerDetails function:

function addCustomerDetails (varName, tagName) {
    window[varName] = $(this).children("time_added");
    $("#"+tagName).html("<p>"+window[varName]+"</p>");
}

So I need a variable name as the argument, so I used window[varName]. Maybe this is also a problem, but I think the $(this) in addCustomerDetails() also doesn't seem work.

I hope I have explained it clearly. Please post any questions if this isn't clear enough and realllly appreciate your help!!

dfsq · Accepted Answer · 2014-12-20 14:42:49Z

2

function addCustomerDetails (tagName) {
    var tag = $(this).children(tagName).text();
    $("#" + tagName).html("<p>" + tag + "</p>");
}

and call it like this:

addCustomerDetails.call(this, "time_added");
addCustomerDetails.call(this, "last_update");

Or following this path you can invent something even more convenient to use:

$(xml).find("customer[value=" + customerID + "]").each(appendTag('time_added', 'last_update'));

where appendTag will look like:

function appendTag() {
    var tags = [].slice.call(arguments);
    return function() {
        for (var i = 0; i < tags.length; i++) {
            var tag = $(this).children(tags[i]).text();
            $("#" + tags[i]).html("<p>" + tag + "</p>");
        }
    };
}

edited Dec 20, 2014 at 14:42

answered Dec 20, 2014 at 14:30

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:05:52Z

0

When you call getCustomerInfo, assuming the caller has access to addCustomerDetails, you can save a reference to it before you make your ajax call and then use that reference to call addCustomerDetails or pass it as the caller if assigned 'self' doesn't have access, like:

var self = this;

$.ajax(
   ....
   self.addCustomerDetails(...);
);

If addCustomerDetails isn't in the context of self, the other option is:

addCustomerDetails.apply(self, ...)

For differences between call and apply, you can check this SO thread:

What is the difference between call and apply?

edited May 23, 2017 at 12:05

CommunityBot

11 silver badge

answered Dec 20, 2014 at 14:31

Nick

4,1226 gold badges33 silver badges43 bronze badges

Collectives™ on Stack Overflow

jquery this pointer scope when call a function in ajax

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related