I try to find all elements whith a particular attribute. For each elements, I want to do something dependant of the value of the attribute.
I did a test to take back the value of the attribute but it doesn't work and I don't see the problem.
HTML:
<div id="t">Test</div>
<div data-test="One">Value One</div>
<div data-test="Two">Value Two</div>
JS:
$("[data-test]").each(function(){
$("#t").append(this.attr("data-test"));
});
JsFiddle link: http://jsfiddle.net/fbue5dpc/
Thank you!
this in your each block refers to the DOM element which does not have the attr method. You should use $(this) to convert it to a jQuery object. You can also improve this further by using the data method to retrieve the values and caching the #t element to reduce the number of DOM retrievals being made:
var $t = $('#t')
$("[data-test]").each(function(){
$t.append($(this).data('test'));
});
var elemnt = $("[data-test]"),frag = "";
elemnt.each(function () {
frag += $(this).attr("data-test");
});
$("#t").append(frag);
selector or you should explain why you changed [data-test] to div[data-test].
RoryMcCrossan already gave a perfectly fine answer with an explanation. SO is not only a place where people get help as individuals, but ideally is a place to help others in future with similar question. So whenever the code of the OP is changed it might look like it is important to solve the problem. I rarely give down-votes. But I always add an comment if it believe a part of the answer can be improved.Try,
$(this).attr("data-test")
Explanation: inside the foreach loop you will get dom element since you are iterating list of dom element. So you cant invoke jquery method directly from dom elemet to do this you have to convert it into a jquery object to do this just use $(this)
Try... answers are not great. As you don't explain what you do and why it is necessary.
$("div[id!='t']").each(function(){
$("#t").append($(this).data('data-test'));
}
$("div[id!='t']") ...?I try to find all elements with a particular attribute..
data-test property only. So this each loop will select onlythose dive which dont have id='t' cz he is adding the attribute value in $("t") innnerHTML.$(this).data('data-test') won't work anyway, it should be either $(this).attr('data-test') or $(this).data('test').