Node.js - File upload with progress

Question

I'm trying to upload a file through curl --upload-file For some reason, curl freezes and upload.backup get created empty. Any ideas how this code should be changed to make it work? I must be misunderstanding the APIs

var http = require('http'); 
var fs = require('fs');
var server = http.createServer(function(request, response) {
    var fileBackup = fs.createWriteStream("upload.backup");
    var fileBytes = request.headers['content-length'];
    var uploadedBytes = 0;
    request.on('readable', function() {
        var chunk = null;
        while (null !== (chunk = request.read())) {
            uploadedBytes += chunk.length;
            var progress = uploadedBytes / fileBytes * 100;
            response.write("progress: " + parseInt(progress, 10) + "%\n");
        }
    });
    request.pipe(fileBackup);
}).listen(8080);

mscdex · Accepted Answer · 2015-06-07 16:23:48Z

1

One issue is that you're not ending your response. Secondly, you're reading the data from the request stream before it can be written to the file.

Try something like this instead:

var http = require('http'); 
var fs = require('fs');
var server = http.createServer(function(request, response) {
  var fileBackup = fs.createWriteStream('upload.backup');
  var fileBytes = parseInt(request.headers['content-length'], 10);
  var uploadedBytes = 0;
  request.pipe(fileBackup);
  if (!isNaN(fileBytes)) {
    request.on('data', function(chunk) {
      uploadedBytes += chunk.length;
      response.write('progress: ' + (uploadedBytes / fileBytes * 100) + '%\n');
    });
  }
  request.on('end', function() {
    response.end();
  });
}).listen(8080);

edited Jun 7, 2015 at 16:23

answered Jun 7, 2015 at 15:52

mscdex

107k15 gold badges201 silver badges159 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Node.js - File upload with progress

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related