Pointers C Linkedlist Adding Always NULL

Question

I've written a function for adding to the end of a singly linked list in C. But what I don't get is why if the head element is NULL, why it continues remaining to be NULL after successive adds.

The struct is defined as this:

typedef struct node* node;

struct node {
    int data;
    node next;
}

In the main I have this:

node test = NULL;
add(test,1);
add(test,2);
add(test,3);

function add is defined as such:

void add(node head, int newData) {
    node n = createNode(newData);
    if (head==NULL) {
        head = n;
        return;
    }
    else {
        node tmp = head;
        while (tmp->next != NULL) {
           tmp = tmp->next;
        }
        tmp = n;
    }
}

createNode is defined as thus:

node createNode(int data) {
    node n = (node) malloc(sizeof(struct node));
    n->next = NULL;
    n->data = data;
    return n;
}

What I am confused about is that, the add function works fine if I first initialize the head (node test = createNode(1)) and then proceeds to add the rest of the values alright. But if I leave the test node to be NULL, it doesn't add any values? What is happening here?

pass node* to your function add, it will work. Also, u need to change the code in ur function accordingly . — Aneesh Dandime
– Aneesh Dandime, Commented Jul 5, 2015 at 15:11
But for the function to work u need to pass a double pointer. Well, i will try to write a proper answer to this. — Aneesh Dandime
– Aneesh Dandime, Commented Jul 5, 2015 at 15:12
Hint: don't typedef pointers, but the struct. This will create less confusion. — too honest for this site
– too honest for this site, Commented Jul 5, 2015 at 15:27

Vlad from Moscow · Accepted Answer · 2015-07-05 15:33:25Z

2

Write function add the following way

void add( node *head, int newData ) 
{
    node n = createNode( newData );

    while ( *head ) head = &( *head )->next;

    *head = n;
}

or you can write even the following way

void add( node *head, int newData ) 
{
    while ( *head ) head = &( *head )->next;

    *head = createNode( newData );
}

and call it like

node test = NULL;

add( &test, 1 );
add( &test, 2 );
add( &test, 3 );

Take into account that function createNode must be declared before function add and you missed a semicolon in the structure definition

struct node {
    int data;
    node next;
}
^^^

Also it is not a good idea to use the same identifier for a struture tag and pointer to the same structure

typedef struct node* node;

At least it would be better to write something like

typedef struct node* node_ptr;

edited Jul 5, 2015 at 15:33

answered Jul 5, 2015 at 15:13

Vlad from Moscow

313k27 gold badges204 silver badges358 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

roostersign Over a year ago

The issue is due to scope, so you are right, also I just found this answer: stackoverflow.com/questions/25780563/… Thanks!

Vlad from Moscow Over a year ago

@roostersign Of course function createNode should be declared before function add.

Collectives™ on Stack Overflow

Pointers C Linkedlist Adding Always NULL

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related