Returning array value from a function inside a class (ASP.net C#)

Question

Service class

public string[] loadSecretQues(string email)
{
    string[] ques= new string[3];

    dbConn = new OdbcConnection(dbConnString);
    dbConn.Open();
    cmd = new OdbcCommand();
    cmd.Connection = dbConn;

    cmd = new OdbcCommand("SELECT q1, q2, q3 FROM Information WHERE EmailAdd = '" + email + "'", dbConn);
    dRead = cmd.ExecuteReader();

    while (dRead.Read())
    {
        if (dRead.HasRows)
        {
            for (int i = 1; i <= 3; i++)
            {
                for (int j = 0; j <= 3; j++)
                {
                    ques[j] = dRead["q" + i].ToString();
                }
                return ques[i];
            }
        }
    }
}

Page.aspx

protected void btnCheck_Click(object sender, EventArgs e)
{
    cmbQues.Items.Add(srvc.loadSecretQues(txtEmail.Text));
}

Good day guys. I am seeking for help. I want to return array values from a function inside a class. The process is, I want to retrieve 3 questions (which are string data type) from my database and store it in a combobox. Any suggestions how to retrieve those three questions? Any other ways? Thanks in advance! :)

Your for i loop will only process the first value 1, as you then return from your function. you need to build up surely an array of arrays and return the whole thing? — BugFinder
– BugFinder, Commented Aug 11, 2015 at 6:57
@BugFinder sorry, I don't get what you are trying to say. Can you show me how to do it, would you mind? ") — paulooooo
– paulooooo, Commented Aug 11, 2015 at 7:06

sujith karivelil · Accepted Answer · 2015-08-11 07:13:44Z

0

You are returning from an inner loop so that rest of iterations ware cancelled, and also you miss to Dispose the command as well as close the open connection. so i suggest you to dispose the command as well as the connection before return, hence the code will be like the following:

no need to check dvc_mst_tdeposit, because if it has no rows control comes out from while. no need for the outer for Loop(i loop) since (j Loop is enough to handle this scenario.

dRead = cmd.ExecuteReader();
while (dRead.Read())
{
    for (int j = 0; j < 3; j++)
      {
         ques[j] = dRead["q" + i].ToString();
      }              
}
dRead.Close();
cmd.Dispose();
dbConn.Close();
return ques;

edited Aug 11, 2015 at 7:13

answered Aug 11, 2015 at 7:10

sujith karivelil

29.1k7 gold badges60 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

paulooooo Over a year ago

I have an error in capturing the items into combobox - The best overloaded method match for 'System.Web.UI.WebControls.ListItemCollection.Add(System.Web.UI.WebControls.ListItem)' has some invalid arguments - cannot convert from 'string[]' to 'System.Web.UI.WebControls.ListItem'

sujith karivelil Over a year ago

so you have to return List<ComboBoxItems> from the function

Community · Accepted Answer · 2017-05-23 11:51:24Z

0

Use List instead of string array.check the link for advantage

public List<string> loadSecretQues(string email)
{
    List<string> ques=new List<string>();

    dbConn = new OdbcConnection(dbConnString);
    dbConn.Open();
    cmd = new OdbcCommand();
    cmd.Connection = dbConn;

    cmd = new OdbcCommand("SELECT q1, q2, q3 FROM Information WHERE EmailAdd = '" + email + "'", dbConn);
    dRead = cmd.ExecuteReader();

 if (dRead.HasRows)
  {
    while (dRead.Read())
    {
      ques.Add(dRead["yourColumnName"].ToString());
    }
  }
return ques;
}

edited May 23, 2017 at 11:51

CommunityBot

11 silver badge

answered Aug 11, 2015 at 7:27

shreesha

1,8812 gold badges23 silver badges32 bronze badges

1 Comment

sujith karivelil Over a year ago

Oh..! List<string> can directly converted to System.Web.UI.WebControls.ListItem

Collectives™ on Stack Overflow

Returning array value from a function inside a class (ASP.net C#)

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related