Java Regex for Nesting Function Calls

Question

I have around 200 function calls of the form

markers.add(packageDecl.getPosition(), "package.invalid", this.fullName);

which need to be replaced with

markers.add(I18n.createMarker(packageDecl.getPosition(), "package.invalid", this.fullName));
            ^^^^^^^^^^^^^^^^^^                                                            ^

They can have an arbitrary number of function arguments and the arguments can be nested calls, as seen in the example. However, it is given that the ; is always succeeded by a newline.

I already tried this regex:

markers\.add\((.*)$

Which allows me to strip the markers.add( part and add the I18n.createMarker(. However, I cannot add the extra closing parenthesis at the end: ); -> ));.

Clashsoft · Accepted Answer · 2015-10-14 16:42:00Z

1

Can you not use this:

Regex:   markers\.add\((.*)\)"
Replace: markers.add(I18n.createMarker(\1))

edited Oct 14, 2015 at 16:42

Clashsoft

11.9k6 gold badges48 silver badges84 bronze badges

answered Oct 14, 2015 at 16:04

Alex Rashkov

10k3 gold badges35 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aaron · Accepted Answer · 2015-10-14 16:29:10Z

0

This ~~ugly thing~~ seems to work with Eclipse regex find :

markers\.add\((.|\n)*;$

answered Oct 14, 2015 at 16:29

Aaron

24.9k2 gold badges41 silver badges61 bronze badges

4 Comments

Alan Moore Over a year ago

You should look up DOTALL mode in the Java regex docs. There's no need for hacks like (.|\n).

Aaron Over a year ago

@AlanMoore I know about regex flags but I don't think the regex search/replace that Clashsoft mentionned in a comment supports them. Am I mistaken?

Alan Moore Over a year ago

The question is tagged java, so I assumed it was for Java code and he was only using Eclipse for testing. But no matter, Eclipse itself uses the ICU library, which has almost exactly the same syntax and semantics as the Java flavor (a deliberate design choice). Oh, and there's another problem with (.|\n). There are several other line separator characters that . doesn't match, so technically, you should have been using. (.|[\r\n\u0085\u2028\u2029]). If you were going that route. Which you shouldn't.

Aaron Over a year ago

@AlanMoore It turned out I had forgotten about flags shorthands in Java so thank you for insisting !

Collectives™ on Stack Overflow

Java Regex for Nesting Function Calls

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related