push object into an array failed

Question

I'm trying to push object into an new array.

var final = [],
  temp_obj = {};

for (var i = 0; i < obj.length; i++) {

  var splitted = obj[i].split(":")[0]
  if (obj[i] != null && obj[i] != '') {
    temp_obj["name"] = splitted;
  }

  final.push(temp_obj);

}

console.log(final)

The result I got is I'm getting same result for my object, which part I did wrong?

What does the code inside of obj look like? Please also include that. — Sam
– Sam, Commented Dec 7, 2015 at 5:03

Norlihazmey Ghazali · Accepted Answer · 2015-12-07 05:02:39Z

1

Assign empty temp_obj inside for loop like following code :

var final = [],temp_obj;  

for (var i = 0; i < obj.length; i++) {
  temp_obj = {};
  var splitted = obj[i].split(":")[0]
  if (obj[i] != null && obj[i] != '') {
     temp_obj["name"] = splitted;
  }

  final.push(temp_obj);
}

console.log(final)

answered Dec 7, 2015 at 5:02

Norlihazmey Ghazali

9,0701 gold badge26 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

FurkanO Over a year ago

where does this obj come from ? The one with obj.lenght

Norlihazmey Ghazali Over a year ago

@FurkanOrhan Another references of course. Assumed for loop already in action. OP problem is The result I got is I'm getting same result for my object, we know that for loop already iterated.

Sam Over a year ago

@FurkanOrhan that's something you should ask OP

Rayon Over a year ago

I think there is no point declaring temp_obj outside of the loop!

Jennifer Aniston Over a year ago

@RayonDabre that's my mistake.

|

Nishan Senevirathna · Accepted Answer · 2015-12-07 05:07:03Z

0

Try to get your null and empty checking condition to one step to the top. Like below, other vice you will get null point issues.

  var final = [],
  temp_obj = {};

for (var i = 0; i < obj.length; i++) {
   temp_obj = {};

  if (obj[i] != null && obj[i] != '') {
    var splitted = obj[i].split(":")[0]
    temp_obj["name"] = splitted;
  }

  final.push(temp_obj);

}

console.log(final)

answered Dec 7, 2015 at 5:07

Nishan Senevirathna

7196 silver badges12 bronze badges

Comments

Mottie · Accepted Answer · 2015-12-07 05:08:25Z

0

The final.push() should be inside the loop (demo)

var obj = [ 'a:b', 'c:d', 'e:f' ], // just guessing
  final = [],
  temp_obj = {};

for (var i = 0; i < obj.length; i++) {

  var splitted = obj[i].split(":")[0];
  if (obj[i] !== null && obj[i] !== '') {
    temp_obj.name = splitted;
    final.push( temp_obj );
  }

}

console.log(final);

answered Dec 7, 2015 at 5:08

Mottie

86.7k30 gold badges132 silver badges248 bronze badges

Collectives™ on Stack Overflow

push object into an array failed

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related