Swift - tableView not reloading after adding to array

Question

I am having an issue updating my UITableView. I have an app that has a basic UIViewController with a with a navigationItem to "Add New" items to the UITableViewContioller. I can add the string and then dump the array to see if it has been added. The dump function shows the added item in the array but the UITableView does not, even after calling reloadData. Here is my code.

Here is the console dump after hitting save.

So you can see something is there after I save but nothing shows up on the UITableview.

From the UIViewController class I have a UIAlertAction to accept text and a save button.

      let table = TableViewController()


        let saveAction = UIAlertAction(title: "Save", style:UIAlertActionStyle.Default, handler: {
        alert -> Void in

        let firstTextField = alertController.textFields![0] as UITextField
        self.table.cityArry.addObject(firstTextField.text!)
        self.table.refresh()
    })

And from UITableViewController class

 class TableViewController: UITableViewController {

var cityArry:NSMutableArray = ["Local"]

override func viewDidLoad() {
    super.viewDidLoad()
    tableView.delegate = self
    tableView.dataSource = self

}


func refresh(){
    dump(cityArry)
    tableView.reloadData()
}

override func tableView(tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
    return cityArry.count

}

override func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) ->   UITableViewCell {
    let item = cityArry[indexPath.row]
    let cell = UITableViewCell()
    let label = UILabel(frame: CGRect(x:20, y:0, width:200, height:50))
    label.text = item as? String
    cell.addSubview(label)

    return cell
}

override func tableView(tableView: UITableView, didSelectRowAtIndexPath indexPath: NSIndexPath) {


    // Nothing here yet

}
}

You sure the table displaying on your screen is the one you call refresh on? — J.Wang
– J.Wang, Commented Mar 1, 2016 at 5:33

sschale · Accepted Answer · 2016-03-01 05:48:33Z

1

I don't think that you should have two separate view controllers for the screen you're showing. Simplification may end up, as @J.Wang alludes to, solve your problem of calling methods on different objects. Your screen should be well handled with a TableViewController embedded in a Navigation Controller that has a button added to it.

answered Mar 1, 2016 at 5:48

sschale

5,1883 gold badges32 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sahil · Accepted Answer · 2016-03-01 05:37:54Z

0

you need to reload data in main thread in refresh function.

dispatch_async(dispatch_get_main_queue(), { () -> Void in
self.tableView.reloadData()
})

answered Mar 1, 2016 at 5:37

Sahil

9,2263 gold badges28 silver badges29 bronze badges

Comments

theMikeSwan · Accepted Answer · 2016-03-01 05:41:59Z

0

Try changing this:

func refresh(){
    dump(cityArry)
    tableView.reloadData() 
}

to this:

func refresh(){
    dispatch_async(dispatch_get_main_queue()) { () -> Void in
        dump(cityArry)
        self.tableView.reloadData()
    }
}

If it happens that refresh() is getting called on anything other than the main thread the table view will likely not update properly. Might not be the issue but its a good first step.

edited Mar 1, 2016 at 5:41

answered Mar 1, 2016 at 5:33

theMikeSwan

4,7492 gold badges33 silver badges45 bronze badges

Collectives™ on Stack Overflow

Swift - tableView not reloading after adding to array

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related