Using 'this' in javascript with Ajax

Question

I'm calling this php file from Ajax and writing the required javascript code in this php file.

<div class="add_people_invite">
    <button class="btn btn-default add_connection" id="right_connection_request" onclick="SentRequestMouseUpRight(event,{{ $peopleMayKnow->id }})">
        <span>My Text</span>
    </button>
</div>

Javascript code :

<script>
    function SentRequestMouseUpRight(event, user_id) {
        if (event.which == 1) {
            alert();
            $("#right_connection_request span", this).text("My NEW Text");
        }
    }
</script>

alert in javascript is working but it is not changing the text to My NEW Text and if I remove this and then I run this code $("#right_connection_request span").text("My NEW Text"); It changes the text.

Why do you need this here anyway? You're using an ID and IDs as such must be unique. — j08691
– j08691, Commented Mar 30, 2016 at 18:48
If you want this to refer to the clicked element, you'd need to use .call(this, … — Bergi
– Bergi, Commented Mar 30, 2016 at 18:51

Raman · Accepted Answer · 2016-03-30 18:59:28Z

1

You can use event.target instead of this keyword. Here is a fiddle to demonstrate the same.

function SentRequestMouseUpRight(event, user_id) {
  if (event.which == 1) {
    $(event.target).text("My NEW Text");
  }
}

answered Mar 30, 2016 at 18:59

Raman

1,28113 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

hodophile Over a year ago

if I want to change onlick function then $(event.target).setAttribute('onclick','writeLED(1,1)') ,this will also work.

Community · Accepted Answer · 2017-05-23 12:14:44Z

0

You may want to look at this first, $(this +"selector") ? $("img",this) possible?

The answer as to why it works one way but not the other I cant really tell by lookign at your example we will need to look at what version of Jquery you are using and a few other factors.

edited May 23, 2017 at 12:14

CommunityBot

11 silver badge

answered Mar 30, 2016 at 18:52

rojobo

4864 silver badges17 bronze badges

1 Comment

hodophile Over a year ago

I had tried this too : $("span", this).text("My NEW Text"); but not working.

Shishir Arora · Accepted Answer · 2016-03-30 21:18:50Z

0

u can change html also if you dont want to change ur javascript, else accepted answer is correct.

<div class="add_people_invite"> <button class="btn btn-default add_connection" id="right_connection_request" onclick="return SentRequestMouseUpRight(this,{{ $peopleMayKnow->id }});"> <span>My Text</span> </button> </div>

'this' is window object in both cases.

edited Mar 30, 2016 at 21:18

answered Mar 30, 2016 at 20:48

Shishir Arora

5,9934 gold badges33 silver badges36 bronze badges

Collectives™ on Stack Overflow

Using 'this' in javascript with Ajax

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related