Using typeof for my generic type parameter

Question

I have this code snippet:

foreach (var item in allClassesINeedList)
{
   var genericMethod = temp.GetType().GetMethod("GenerateDocument").MakeGenericMethod(typeof(item));
   genericMethod.Invoke(temp, new object[] { item });
}

This throws an error:

"The type or namespace name 'item' could not be found (are you missing a using directive or an assembly reference?)"

My aim is to execute for every object in allClassesINeedList(its a List<object>) my generic method GenerateSingleDocument with every object in that list.

What did I do wrong ?

Musakkhir Sayyed · Accepted Answer · 2016-04-28 05:38:01Z

3

You can Replace typeof(item) with item.GetType()

edited Apr 28, 2016 at 5:38

Musakkhir Sayyed

7,21813 gold badges44 silver badges67 bronze badges

answered Apr 28, 2016 at 5:29

izsl

715 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

yaakov Over a year ago

To expand - typeof only works on a type known the compiler at compile-time, e.g. typeof(IDisposable). To find the type of an object, use GetType().

Alsty · Accepted Answer · 2016-04-28 09:16:59Z

1

Do you need to use reflection? If you have control of the classes that you are iterating over, it would be better to create an interface. Reflection is slow and should be avoided where possible.

public interface IDocumentCreator
{
    void GenerateDocument();
}

Add this interface to your classes:

public class YourClass : IDocumentCreator
{
    // ...

    public void GenerateDocument()
    {
        // ...
    }
}

And then make a List<IDocumentCreator> instead of List<object>. You can then call the method in the normal way:

List<IDocumentCreator> allClassesINeedList = ...
foreach(IDocumentCreator item in allClassesINeedList)
{
    item.GenerateDocument();
}

answered Apr 28, 2016 at 9:16

Alsty

84710 silver badges23 bronze badges

1 Comment

kkkk00999 Over a year ago

I like your approach, but in my case I have to use relfection, but thxs :)

Collectives™ on Stack Overflow

Using typeof for my generic type parameter

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related