Using JQuery to change CSS top

Question

I wanted to put text over an image so i used a CSS to to do that. But since i use Bootstap to make it and i felt like putting absolute positions in the CSS file i ran into problems when resizing (text wasn't centered) , so i made a JQuery script to handle width change, but it doesn't work

WidthChangeScript.js

if($(window).width() > 500){
$( "#FactionsWidthtoPos" ).css( "top","255px" );
}

index.html

<head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title>GrassCraft</title>
    <!----Bootstrap---->
    <link href="CSS/bootstrap.min.css" rel="stylesheet">
    <link href="CSS/textoverimage.css" rel="stylesheet">

</head>

<body>
    <nav class="navbar navbar-default navbar-fixed-top">
        <div class="container">


            <!-- Brand and toggle get grouped for better mobile display -->
            <div class="navbar-header">
                <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#bs-example-navbar-collapse-1" aria-expanded="false">
                    <span class="sr-only">Toggle navigation</span>
                    <span class="icon-bar"></span>
                    <span class="icon-bar"></span>
                    <span class="icon-bar"></span>
                </button>
                <a class="navbar-brand" href="#">Brand</a>
            </div>

<!-- Collect the nav links, forms, and other content for toggling -->
            <div class="collapse navbar-collapse" id="bs-example-navbar-collapse-1">
                <ul class="nav navbar-nav">
                    <li><a href="#">Forums</a></li>
                    <li class="dropdown">
                        <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Shop<span class="caret"></span></a>
                        <ul class="dropdown-menu">
                            <li><a href="#">Factions Grass</a></li>
                            <li><a id="FctQu" href="#" >Factions Quartz</a></li>
                            <li role="separator" class="divider"></li>
                            <li><a href="#">How it works</a></li>
                        </ul>
                    </li>
                </ul>
                <form class="navbar-form navbar-left" role="search">
                    <div class="form-group">
                        <input type="text" class="form-control" placeholder="Search">
                    </div>
                    <button type="submit" class="btn btn-default">Submit</button>
                </form>
                <ul class="nav navbar-nav navbar-right">
                    <li><a href="#"></a></li>
                    <li class="dropdown">
                        <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Dropdown <span class="caret"></span></a>
                        <ul class="dropdown-menu">
                            <li><a href="#">Action</a></li>
                            <li><a href="#">Another action</a></li>
                            <li><a href="#">Something else here</a></li>
                            <li role="separator" class="divider"></li>
                            <li><a href="#">Separated link</a></li>
                        </ul>
                    </li>
                </ul>
            </div><!-- /.navbar-collapse -->

        </div>
    </nav>
<!---Site body--->
    <div id="imgTop" class="imageBehindText">
        <img src="http://placehold.it/1920x800" class="img-responsive"  width="1980" height="800">  
        <h2 id="FactionsWidthtoPos" class="textOverImage" >Factions</h2>
    </div>
    <div class="placeHolderImage">
        <img src="http://placehold.it/1920x100" class="img-responsive"  width="1980" height="800">>
    </div>
    <div class="container">
        <div class="jumbotron">
            <h1 id="abtUs" > GrassCraft</h1> 
            <p id="abtUsTxt" >A new Factions server made by 2 young enthusiasts. Any financial support would mean alot</p> 
        </div>
    </div>






        <!----Botstrap required JQuery---->
    <script src="jquery.min.js"></script>

    <script src="JavaScript/bootstrap.min.js"></script>
    <script src="JavaScript/WidthChangeScript.js"></script>
</body>

textoverimage.css

 .imageBehindText { 
  position: relative; 
  width: 100%; /* for IE 6 */
  }

 .textOverImage { 
  position: absolute; 
  top: 100px;
  text-align: center;
  width: 100%; 
  color: #f0f8ff;
  text-decoration: underline;
  }
  .placeHolderImage {
  opacity: 0;

  }

This is pretty much all the code for this website also if u know any way I can optimize the code please say

better to ask at codereview.stackexchange.com

StepUp
– StepUp

2016-05-23 07:23:09 +00:00
Commented May 23, 2016 at 7:23 — StepUp
– StepUp, Commented May 23, 2016 at 7:23

Garvit Mangal · Accepted Answer · 2016-05-14 20:09:42Z

1

You can put your code inside resize event handler of jquery like this

  $(document).ready(function(){
     function resize(){
       if($(window).width() > 500){
         if(!$( "#FactionsWidthtoPos" ).hasClass("something"))
           $( "#FactionsWidthtoPos" ).addClass("something");
       }else{
         if($( "#FactionsWidthtoPos" ).hasClass("something"))
           $( "#FactionsWidthtoPos" ).removeClass("something");
    }
  }
  resize();
  $(window).resize(function(){
    resize();
  });
});

your css file will contain a new class like

.something{
   top : 255px;
}

you can also use media query to update your css on window size change like this

@media only screen and (min-width: 500px) {
.textOverImage {
    top : 255px;
 }
}

this media query automatically update your .textOverImage class when your window size is min 500px

edited May 14, 2016 at 20:09

answered May 14, 2016 at 20:02

Garvit Mangal

9007 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Using JQuery to change CSS top

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related