StackoverflowException when filling array

Question

I usually spend my time reading and trying to answer the Excel VBA questions but I am trying to learn C# now. Can someone help me understand why I get a StackOverflowException error on the second to last line in my code?
I am trying to fill an array via a method.

namespace ConsoleApplication1
{
    class Program
    {
        static void Main(string[] args)
        {
            int[] numbers = GenerateNumbers();
            Console.WriteLine(numbers);
            Console.ReadKey();
        }
        static int[] GenerateNumbers()
        {
            int[] num = new int[10] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 };
            return GenerateNumbers();
        }
    }
}

What do you think return GenerateNumbers(); does? This is important to know to correct your misunderstanding. — usr
– usr, Commented Jun 14, 2016 at 14:03
use return num; or just numbers = Enumerable.Range(1,10); — Ňɏssa Pøngjǣrdenlarp
– Ňɏssa Pøngjǣrdenlarp, Commented Jun 14, 2016 at 14:05

Camilo Terevinto · Accepted Answer · 2016-06-14 14:07:45Z

10

You are confusing the weird VBA way of returning functions with C#. You are returning an infinite recursion, which can be easily fixed by using this:

    static int[] GenerateNumbers()
    {
        int[] num = new int[10] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 };
        return num; //you don't return the function name but a variable
    }

answered Jun 14, 2016 at 14:07

Camilo Terevinto

32.2k7 gold badges95 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Twahanz · Accepted Answer · 2016-06-14 14:11:06Z

5

A stack overflow is an undesirable condition in which a particular computer program tries to use more memory space than the call stack has available. In programming, the call stack is a buffer that stores requests that need to be handled. http://whatis.techtarget.com/definition/stack-overflow

 static int[] GenerateNumbers()
 {
     int[] num = new int[10] { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 };
     return GenerateNumbers(); //Here is where the problem happens
 }

The problem lies with the return part. You are calling the same function in the same function creating a stack of the same function again and again and... You get the picture.

Change it to

return num;

edited Jun 14, 2016 at 14:11

answered Jun 14, 2016 at 14:07

Twahanz

2241 silver badge15 bronze badges

1 Comment

Twahanz Over a year ago

@Mafii Thank you for the heads up. I have edited the answer.

Andrew · Accepted Answer · 2016-06-14 14:08:43Z

0

By calling return GenerateNumbers() at the end of your function, you are running that function over and over again infinitely because there is no way to break the recursion, causing the stack overflow. You should instead use return num

answered Jun 14, 2016 at 14:08

Andrew

3882 silver badges9 bronze badges

Comments

Rytis I · Accepted Answer · 2016-06-14 14:11:00Z

0

This is what you're esentially doing:

void Main() 
{
    FlipPage();
}

void FlipPage()
{
    FlipPage();
}

So like that blond you keep flipping that page in all eternity

answered Jun 14, 2016 at 14:11

Rytis I

1,34311 silver badges21 bronze badges

Collectives™ on Stack Overflow

StackoverflowException when filling array

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related