Angular LocalStorage

Question

Hi guys i am trying to save some information with localStorage in angular, i injected $window to my service and i created a factory call $localStorage

.factory('$localStorage', ['$window', function($window) {
        return {
            store: function(key, value) {
            $window.localStorage[key] = value;
            },
            get: function(key, defaultValue) {
            return $window.localStorage[key] || defaultValue;
            },
            storeObject: function(key, value) {
            $window.localStorage[key] = JSON.stringify(value);
            },
            getObject: function(key,defaultValue) {
            return JSON.parse($window.localStorage[key] ||     defaultValue);
            }
        }
        }])

i have other factory where i make us of the localStorage factory in order to save some favorites

factory("favoriteFactory", ["$resource", "baseURL", "$localStorage", function($resource, baseURL, $localStorage) {
        var favFac = {};
        var favorites = $localStorage.getObject("favorites", "[]");

        favFac.addToFavorites = function(index) {
            for (var i = 0; i < favorites.length; i++) {
                if (favorites[i].id == index)
                    return;
            }

            $localStorage.storeObject("favorites", {id: index});
            //favorites.push({id: index});
        };

        favFac.deleteFromFavorites = function (index) {
            for (var i = 0; i < favorites.length; i++) {
                if (favorites[i].id == index) {
                    favorites.splice(i, 1);
                }
            }
        }

        favFac.getFavorites = function () {
            return favorites;
        };

        return favFac;
    }])

the problem is when i add a favorite item, it replaces itself in my array, instead of adding a new one to the array,

i really aprecciate the help thanks in advance

Zohaib Ijaz · Accepted Answer · 2016-06-19 20:03:02Z

2

You are doing wrong while storing. You are replacing an array with a single item. One more thing to note that, Array.prototype.push() return the length of the collection.

enter code herefavFac.addToFavorites = function(index) {
        for (var i = 0; i < favorites.length; i++) {
            if (favorites[i].id == index)
                return;
        }
        favorites.push({id: index})
        $localStorage.storeObject("favorites", favorites);
        //favorites.push({id: index});
    };

edited Jun 19, 2016 at 20:03

answered Jun 19, 2016 at 19:56

Zohaib Ijaz

23k7 gold badges43 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

M. Junaid Salaat Over a year ago

Array.prototype.push() does not return the item. it returns the length

Zohaib Ijaz Over a year ago

@mJunaidSalaat Thank you Junaid, I actually tried to push 4 in an array [1,2,3] and it returned me 4, so I thought it returns item. Thanks for correction. but bad for negative vote :P

M. Junaid Salaat Over a year ago

No problem. You can edit your answer and I'll remove the negative vote and at first you didn't answered the question correctly that's why I made an answer but you edited it later. :)

M. Junaid Salaat · Accepted Answer · 2016-06-19 19:59:09Z

1

You just need to change addToFavorites method like

favFac.addToFavorites = function(index) {
            for (var i = 0; i < favorites.length; i++) {
                if (favorites[i].id == index)
                    return;
            }

            favorites.push({id: index});
            $localStorage.storeObject("favorites", favorites);

        };

Now it will add an item first then save your array into the local storage.

answered Jun 19, 2016 at 19:59

M. Junaid Salaat

3,8031 gold badge25 silver badges27 bronze badges

Comments

Morteza Tourani · Accepted Answer · 2016-06-23 00:36:47Z

0

As an advice I suggest you to use ngStorage which enables you to add or remove item from localStorage as simples as a single command:

$localStorage.favorites = [];

That's it and now you have favorites list in localStorage and any time you modify this array you will get results directly on localStorage.

$localStorage.favorites.push(newItemToAdd); // this adds a item.
$localStorage.favorites = $localStorage.favorites
    .filter((v, i) => i !== indexOfItemToDelete); // removes item.

answered Jun 23, 2016 at 0:36

Morteza Tourani

3,5665 gold badges44 silver badges48 bronze badges

Collectives™ on Stack Overflow

Angular LocalStorage

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related