JavaScript: How to execute an if/else statement in an onclick attribute?

Question

I'm getting syntax errors while trying to add an if/else statement the onclick attribute. What is the syntax for this?

<div onclick="var element = $('#selector'); if (element.val() == 'something') { alert('hello'); } else { alert('goodbye'); } ">
    Click here 
    <input type="hidden" id="selector" value="something" />
</div>

...and yes, I must have this javascript in the onclick attribute (can't move this to a function).

user113716 · Accepted Answer · 2010-09-28 20:12:31Z

5

.val() is a jQuery method. You want to access the value property of the DOM element.

if (element.value == 'something') {

Or create a jQuery object if you have jQuery loaded:

if ($(element).val() == 'something') {

If you took that approach, you could always use a jQuery selector:

if ($('#selector').val() == 'something') {

answered Sep 28, 2010 at 20:12

user113716

323k64 gold badges454 silver badges441 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Andrew Over a year ago

sorry, got mixed up since I'm using jQuery. I've updated my code sample, but that's still not the problem I'm having.

user113716 Over a year ago

@Andrew - I don't get any errors using your code. What do the errors say, and which browser are you using? Also, are you sure you have jQuery loaded?

SLaks · Accepted Answer · 2010-09-28 20:11:37Z

2

Javascript DOM elements do not have a val() function. (Are you thinking of jQuery?)

Change .val() to .value.

If you are thinking of jQuery, you can write if ($('#selector').val() == 'something').

answered Sep 28, 2010 at 20:11

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

1 Comment

Andrew Over a year ago

sorry, got mixed up since I'm using jQuery. I've updated my code sample, but that's still not the problem I'm having.

Collectives™ on Stack Overflow

JavaScript: How to execute an if/else statement in an onclick attribute?

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related