Assign False and '' to javascript variables from c#

Question

I pass model with default values (Id = 0, CityId = null, IsPublished = false) from controller to view:

public class MyModel
{
    public int Id { get; set; }
    public int? CityId { get; set; }
    public bool IsPublished { get; set; }
}

And in view I assign values from model to variables in javascript - cityId should be in javascript type of bool and isPublished should be in javascript null or type of int:

<script>    
    var cityId = @Model.CityId; // value: False
    var isPublished = @Model.IsPublished; // value: ''
</script>

But I have errors:

For cityId: Uncaught ReferenceError: False is not defined
For isPublished: Uncaught SyntaxError: Unexpected token ;

What should I do ?

Have you checked what the actual output in the HTML is? For starters C# coerces false to 'False', so you'll have an issue with case sensitivity there — Rory McCrossan
– Rory McCrossan, Commented Jul 7, 2016 at 12:36
var cityId = @Html.Raw(Json.Encode(Model.CityId)) (ditto for IsPublished) — user3559349
– user3559349, Commented Jul 7, 2016 at 12:39
Are you sure your bool IsPublished is giving ''? And your int CityId giving 'False' ? — fdomn-m
– fdomn-m, Commented Jul 7, 2016 at 13:33

Satpal · Accepted Answer · 2016-07-07 12:40:29Z

4

You can use Json.Encode Method converts a data object to a string that is in the JavaScript Object Notation (JSON) format.

var settings = @Html.Raw(Json.Encode(Model))

Then it can used like

var cityId = settings.CityId; 
var isPublished = settings.IsPublished;

answered Jul 7, 2016 at 12:40

Satpal

134k13 gold badges168 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jamiec · Accepted Answer · 2016-07-07 12:40:04Z

3

For the boolean, always lowercase it:

var isPublished = @Model.IsPublished.ToString().ToLowerInvariant();

For the nullable, check it has a value and give javascript something by default:

var cityId = @Model.CityId ?? "null";

edited Jul 7, 2016 at 12:40

answered Jul 7, 2016 at 12:38

Jamiec

136k15 gold badges143 silver badges202 bronze badges

2 Comments

MrChudz Over a year ago

var cityId = @Model.CityId ?? "null"; - it doesn't work :(

Jamiec Over a year ago

@MrChudz care to elaborate? You get any error message?

ADreNaLiNe-DJ · Accepted Answer · 2016-07-07 12:37:50Z

0

It's because your code is implicitly execute with ToString.

So C# bool.ToString() returns either True or False.

In Javascript, it's lowercase: true or false.

So you have to write it like this:

<script>    
    var cityId = @Model.CityId; // value: False
    var isPublished = @Model.IsPublished.ToString().ToLower(); // value: ''
</script>

answered Jul 7, 2016 at 12:37

ADreNaLiNe-DJ

4,8994 gold badges28 silver badges35 bronze badges

Collectives™ on Stack Overflow

Assign False and '' to javascript variables from c#

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related