Ruby - read each line in file to object and add object to array

Question

I am very new to Ruby and trying to read each line of a file. I want to create an object called LineAnalyzer using each line and then add that object to an array called analyzers.

The code I am trying is

Class Solution 
    attr_reader :analyzers;

    def initialize()
      @analyzers = Array[];
    end

    def analyze_file()
      count = 0;

      f = File.open('test.txt')

      #* Create an array of LineAnalyzers for each line in the file

      f.each_line { |line| la = LineAnalyzer.new(line, count) }
          @analyzers.push la;
          count += 1;   
      end
    end
end

Any help or suggestions would be greatly appreciate!!

Array[] is not what you mean. [] is sufficient. Empty argument lists on methods are also omitted by convention, so it's simply initialize. — tadman
– tadman, Commented Jul 16, 2016 at 12:16

Harsh Trivedi · Accepted Answer · 2016-07-16 12:09:26Z

4

If I have understood you correctly, this should work:

class Solution 
    attr_reader :analyzers

    def initialize()
      @analyzers = []
    end

    def analyze_file()
      count = 0;
      File.open('test.txt').each_line do |line| 
          la = LineAnalyzer.new(line, count) 
          @analyzers.push la
          count += 1
      end
    end
end

Little digressing from question, please note that - at most places in ruby you don't need ;. Ruby is good so it doesn't complain about it, but its good to stay with the standard conventions.

edited Jul 16, 2016 at 12:09

answered Jul 16, 2016 at 7:32

Harsh Trivedi

1,63415 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

tadman Over a year ago

Worth mentioning ; is only necessary for collapsing multiple lines together, sometimes that's handy for things like x.each { |y| y.do_thing; y.do_other }. They shouldn't be present unless you're doing that even though they are otherwise ignored.

Harsh Trivedi Over a year ago

True. That's exactly and only the case in which I use ; in ruby.

Collectives™ on Stack Overflow

Ruby - read each line in file to object and add object to array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related