Add to Integer Variable from Rails Controller

Question

This should be a fairly simple error to fix (I hope). When a joke on my app is approved, I want that user to be awarded 5 manpoints (don't ask). I currently have this in my 'jokes_controller`:

  def approve
    @joke = Joke.find(params[:id])
    @joke.update_attributes(approved: true)
    if @joke.user.manpoints = nil
      @joke.user.manpoints = 5
    else
      @joke.user.manpoints += 5
    end
    @joke.save
    redirect_to jokes_path
  end

I'm getting this error when I try to approve a joke:

undefined method `+' for nil:NilClass

I thought += was the "Ruby way" to do this? Can anyone set me straight?

try changing @joke.user.manpoints = nil to @joke.user.manpoints.nil? and @joke.user.manpoints == nil should be the correct syntax — mrvncaragay
– mrvncaragay, Commented Aug 14, 2016 at 0:14

user1201917 · Accepted Answer · 2016-08-14 00:21:20Z

0

Change = in if condition to ==. I assume you need to compare manpoints with nil, not to assign nil to manpoints. It should be like:

if @joke.user.manpoints == nil
  ...

You can omit == operator here:

unless @joke.user.manpoints
  ...

PS. Why are you excepting that manpoints will be nil?

edited Aug 14, 2016 at 0:21

answered Aug 14, 2016 at 0:16

user1201917

1,3701 gold badge14 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Liz Over a year ago

Those changes get rid of the error, but the user's manpoints are still nil after the approve action.

user1201917 Over a year ago

You need to save the user instance. Save it with @joke.user.save.

Liz Over a year ago

Perfect! Thank you!

user1201917 Over a year ago

You're welcome :) btw, you can avoid the comparison. Use default value with migration. related info

Collectives™ on Stack Overflow

Add to Integer Variable from Rails Controller

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related