Using string.Join() to avoid a trailing comma

Question

I'm trying to put together a list of email addresses into a string, like this:

string bcc = string.empty
foreach (contact as Contact in contacts)
{
    bcc = bcc + contact.Email + ","
}

The problem with that approach is that the final string has a trailing comma. Not a huge deal, but I'd like to avoid it, just to be tidy. So, I tried this:

bcc = bcc.Join(",", contact.Email);

But that throws an error:

Member 'string.Join(string, params string[])' cannot be accessed with an instance reference; qualify it with a type name instead

So, I tried this:

bcc = String.Join(",", contact.Email);

But that just clears out bcc each time and all I end up with is the last email address. So, I tried this:

bcc = bcc + string.Join(",", contact.Email);

But that gets me a long string of un-delimited emails with no comma separation.

I'm sure when I see the solution, I'll smack my forehead. But I'm not grasping it.

Just to add to Peter B, you use the Join (a static method) on string class not bcc instance. — Cetin Basoz
– Cetin Basoz, Commented Dec 6, 2016 at 17:07

Peter B · Accepted Answer · 2016-12-06 16:58:45Z

11

This is what you should use:

// using System.Linq;
bcc = string.Join(",", contacts.Select(c => c.Email));

And then you don't need the foreach anymore, Linq does it for you.

answered Dec 6, 2016 at 16:58

Peter B

24.7k5 gold badges42 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

A. Almazidi · Accepted Answer · 2022-10-29 10:40:54Z

-2

Adding to @Peter's answer, and from this you can join then trim last comma:

bcc = string.Join(",", contacts.Select(c => c.Email)).TrimEnd(',');

answered Oct 29, 2022 at 10:40

A. Almazidi

751 silver badge5 bronze badges

2 Comments

Hans Keﬆing Over a year ago

No need to trim the last comma, Join doesn't add that

benderto Over a year ago

This does not provide an answer to the question. Once you have sufficient reputation you will be able to comment on any post; instead, provide answers that don't require clarification from the asker. - From Review

Collectives™ on Stack Overflow

Using string.Join() to avoid a trailing comma

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related