ActiveAdmin nested form duplicate

Question

I know there are multiple questions with a similar title to this, but I haven't found anything that resembled my problem. If there is already a solution and thus my question is a duplicate, I'm sorry - I just didn't find it, it's not that I didn't search.

I'm using ActiveAdmin with the ActiveSkin theme. I have a form for my model Agent where I want to use the nested forms for a has_many relation. I created this code in a partial:

<%= semantic_form_for [@agent], builder: ActiveAdmin::FormBuilder do |f| %>
    <%= f.semantic_errors %>
    <%= f.inputs 'General Information' do %>
        <%= f.input :name %>
        <%= f.input :description %>
    <% end %>
    <%= f.inputs 'Capture Columns' do %>
        <%= f.has_many :capture_columns, new_record: 'Add Column' do |column| %>
            <%= column.input :column_name %>
            <%= column.input :column_datatype %>
        <% end %>
    <% end %>
    <%= f.actions do %>
        <%= f.action :submit %>
        <li class="cancel"><%= link_to 'Cancel', :back %></li>
    <% end %>
<% end %>

Basically, this is working, but it looks like this:

Why is the html duplicated (I checked it, it's exactly the same)? What am I doing wrong?

EDIT: The inner HTML for the nested form is duplicated, too:

Version of Rails? Version of ActiveAdmin? (try pre5). My first response would be to rewrite the partial in Arbre (.arb not .erb), eg. activeadmin.info/5-forms.html — Piers C
– Piers C, Commented Mar 18, 2017 at 19:22
Rails 5.0.2 and AA from the current master branch. why do you think that abre works better? — Florian Koch
– Florian Koch, Commented Mar 18, 2017 at 19:38
As Fivell mentions in the GH issue the tests cover using .arb much better than .erb, which is more of an afterthought. — Piers C
– Piers C, Commented Mar 18, 2017 at 23:13
f.inputs in Arbre overrides and is slightly different from f.inputs using just Formtastic. <%- as suggested is worth trying also. — Piers C
– Piers C, Commented Mar 18, 2017 at 23:27

Florian Koch · Accepted Answer · 2017-03-20 16:23:54Z

3

+50

Not saying it's the right behavior, but according to the docs, you need to avoid printing to the template when using has_many.

Try using <%- or <% instead of <%= in the f.has_many declaration and block.

edited Mar 20, 2017 at 16:23

Florian Koch

1,5321 gold badge31 silver badges53 bronze badges

answered Mar 18, 2017 at 22:44

deivid

5,3382 gold badges37 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

deivid Over a year ago

I'm pretty sure it's going to work, I run into this myself yesterday! xD

Florian Koch Over a year ago

I also had to use <% for the has_many block itself, but yeah, it works! Thanks a lot!

deivid Over a year ago

Yes, that's the only place that needs changing, actually! I'll clarify the answer.

Florian Koch Over a year ago

no, I must not use <%= inside of has_many either, else the content is printed twice

deivid Over a year ago

mmmmm. I thought I tried this, but since this is what the docs say, and you have tried it for sure... I accepted your edit! Thanks :)

fabOnReact · Accepted Answer · 2017-03-14 07:28:20Z

1

There is a loop hear. The problem is simple to solve, just get in the loop and understand why it is looping and how to fix it. You should use binding.pry to test it. You can set a breakpoint in the form with <% binding.pry %> or you can print variables like <% puts column %> in your server log.

  <%= f.has_many :capture_columns, new_record: 'Add Column' do |column| %>
        <%= column.input :column_name %>
        <%= column.input :column_datatype %>
    <% end %>

answered Mar 14, 2017 at 7:28

fabOnReact

5,9424 gold badges20 silver badges63 bronze badges

4 Comments

Florian Koch Over a year ago

I'll give it a try

Florian Koch Over a year ago

I struggled using pry, but I tried to debug it with the normal console and wasn't able to extract any useful information...

fabOnReact Over a year ago

@FlorianKoch it would be helpful if you would print in you server log 2 variables <% puts f.capture_columns %> before the f.has_many :capture_columns and inside that <% puts column %> <% puts column.input %> Vielen Dank :)

Florian Koch Over a year ago

the first (slightly modified to f.object.capture_columns) doesn't output anything, column is printed as #<ActiveAdmin::FormBuilder:0xd021068> and column.input isn't something I can put

Collectives™ on Stack Overflow

ActiveAdmin nested form duplicate

2 Answers 2

5 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related