how to get the name list from the db using function in php

Question

This is my code to get name list from the database but I am not able to get values where is the error can anyone pls help me 

// database connection where php is my database name
<?php
$con=mysql_connect("localhost","root","root");
mysql_select_db("php",$con);
?>

// html body for getting value in option

<!DOCTYPE html>
<html>
<head>
    <title></title>
</head>
<body>
<form method="post">
<select name="select" >
    <option>Select College From Here</option>
     <?php $getoptions = get_name(); ?>
    <?php foreach ($getoptions as $key => $value) { ?>
        <option><?= $value ?></option>
    <?php } ?>
</select>
<input type="submit" name="sub">

</form>

// function to get name list from the database is this query right or wong ??
<?php
function get_name(){
    $option=array();
    $query="select * From login ";
    $result=mysql_query($query);
    while($row=mysql_fetch_array($result)){
        $option [$row->id] = strtoupper($row->name);
            }
$option;
}
?>

Help me regarding this that function not returning me the name from the table and m not able to see the list on select box.. and tell me how can i see the what function is going to return how to get function return value, can i alert the return value or echo the value

FYI, you shouldn't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which one is best for you. — John Conde
– John Conde, Commented Apr 17, 2017 at 12:53
You don't know what's wrong because you don't check for errors in your code. Never assume the code is always going to work flawlessly. Use mysql_error() to get a detailed error message from the database. — John Conde
– John Conde, Commented Apr 17, 2017 at 12:53
You're fetching data as an array and then trying to access it as an object. If you turned on error reporting PHP would have warned you about this. — John Conde
– John Conde, Commented Apr 17, 2017 at 12:54

Shafiqul Islam · Accepted Answer · 2017-04-17 13:15:33Z

1

try this but not tested

   function get_name()
{
// your code
    while($row=mysql_fetch_array($result)){
        $id = $row['id'];
        $option [$id] = strtoupper($row['name']);
    }
    return $option;

}

check this for test

while ($row = mysqli_fetch_assoc($result)) {
        $id = $row['id'];
        echo $id . "==" . $row['name'];
        echo "<br>";

        $option [$id] = strtoupper($row['name']);
    }
    $option;
    print_r($option);

edited Apr 17, 2017 at 13:15

answered Apr 17, 2017 at 12:58

Shafiqul Islam

5,6852 gold badges36 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

Shafiqul Islam Over a year ago

check last section for testing if everything fine

Shafiqul Islam Over a year ago

i think you missed return $option. so please check now

Gaurav Pandey Over a year ago

Shafiqul Islam Over a year ago

this is separate function

Shafiqul Islam Over a year ago

<?php function get_name() { $con = mysql_connect("localhost", "root", "root"); mysql_select_db("php", $con); $option = array(); $query = "select name,id from login"; $result = mysql_query($query); while ($row = mysql_fetch_assoc($result)) { $option [$row['id']] = $row['name']; } return $option; }

|

Gandhivasan · Accepted Answer · 2017-04-17 13:31:44Z

0

should replace this

while($row=mysql_fetch_array($result)){
   $option [$row->id] = strtoupper($row->name);
        }

$option;

by this code

while($row=mysql_fetch_array($result)){
    $option [$row['id']] = strtoupper($row['name']);
        }

return $option;

answered Apr 17, 2017 at 13:31

Gandhivasan

113 bronze badges

1 Comment

Jay Blanchard Over a year ago

Why should the OP "replace" this? A good answer will always have an explanation of what was done and why it was done in such a manner, not only for the OP but for future visitors to SO.

Collectives™ on Stack Overflow

how to get the name list from the db using function in php

2 Answers 2

11 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

11 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related