Nested loop? ValueError?

Question

I have a question about Nested loops, primarily converting the lists into an int and then testing to see if it is less than a limit(230) and if it is, it adds one to the limit and one to a count. Here's the code I have so far Whenever I try to work this code: I get an Error message of:

ValueError: invalid literal for int() with base 10: '487 , 440 , 488 , 496 , 55 , 345 , 26 , 446 , 249 , 402 , 311\n'

I think it means that im trying to take the int of that whole string? How could I split it up so that it takes the int of 487, 440, 488, etc

def Nested_Loop():

    count = 0
    lines = []
    limit = 230
    listt = open ('numbers.txt', 'r')
    value = listt.readlines()
    for line in value:
        lines.append(line)

    for line in lines:
        line = int(line)

    if line < limit:
        limit = limit + 1
        count = count + 1
    else:
        line = limit + 0
        count = count + 0

Nested_Loop()

I don't know how to upload the numbers.txt on here, but here is a picture of it.

Wondering: what effects do you expect to gain from that else block up there? What is the point of adding 0 to something? — GhostCat
– GhostCat, Commented Apr 27, 2017 at 6:44
So that if the numbers are greater than the limit, the count and limit stay the same and it reads the next value in the .txt — A cool guy
– A cool guy, Commented Apr 27, 2017 at 6:47
When you read a line from a file, it is always a string. Convert them to array might be suitable in your case. You can convert string in to an array by using "split" function. And you could do the opposite option using "join" function. These two functions are standard name for many programming languages. — pupuupup
– pupuupup, Commented Apr 27, 2017 at 6:49
The code you have right now can only work if you have one integer per line in that file. Try what Hackaholic suggests. — TheWaveLad
– TheWaveLad, Commented Apr 27, 2017 at 6:49
for example: str = "123,456,789" ; str.split(',') will return array of string as such ['123', '456', '789'] then you could turn them in to integer. — pupuupup
– pupuupup, Commented Apr 27, 2017 at 6:51

Hackaholic · Accepted Answer · 2017-04-27 06:54:25Z

1

you better do like this:

read a line from file, split on comma

with open('numbers.txt') as f:
    for line in f:
        nums = list(map(int, line.strip().split(",")))
        if len(nums)< limit:
        # now your code

edited Apr 27, 2017 at 6:54

answered Apr 27, 2017 at 6:47

Hackaholic

19.8k6 gold badges59 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

A cool guy Over a year ago

TypeError: object of type 'map' has no len()

Hackaholic Over a year ago

are you using python 3.x, Updated the solution

pupuupup Over a year ago

print "line" variable to check its data type before using it. strip and split is a string function

A cool guy Over a year ago

Thanks for the help!

Collectives™ on Stack Overflow

Nested loop? ValueError?

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related