C Using array values erases array

Question

I am confused, when i use array values to assign another array values. the original array deletes the values used

int main(int argc, char *argv[]) {

    char original[ORIGINAL_SIZE];
    int isbn[ISBN_SIZE];
    int index = 0;
    int code;
    int weight = 10;
    int weightedValue;
    int weightedSum = 0;

    printf("Enter an ISBN to validate: ");
    validateISBNArray(original);

    while(index < ORIGINAL_SIZE){
        if(original[index] != '-'){
            if(original[index] == 'x' || original[index] == 'X') isbn[index] = 10;
            else if(original[index] == 0) isbn[index] = 0;
            else isbn[index] = original[index]-48;
            code = isbn[index];
            //printf("%d", code);
            weightedValue= code*weight;
            weight--;
            weightedSum += weightedValue;
        }
        index++;
    }
    printf("%s",original);
    if(weightedSum%11==0) printf("The ISBN %s, is VALID", original);
    else printf("The ISBN %s, is NOT VALID", original);

    return 0;
}

validateISBNArray has no effect on original array

this is the code for the not affecting function

void validateISBNArray(char array[]){

    int index = 0;
    int countDigits = 0;
    int value = 0;  

    clearArray(array, ORIGINAL_SIZE);
    scanf("%s",array);      

    while(index < ORIGINAL_SIZE){
        //printf("%d %c %d\n", index, array[index], countDigits);
        if(((array[index]-48) >= 0 && (array[index]-48) <= 9) || (array[index] == 'x'|| array[index] == 'X')) {
            countDigits++;
            index++;
        }
        else if(array[index] == '-' || array[index] == 0) index++;
        else{
            printf("INVALID CHARACTER %d = %c. Please Enter Digits Or/And Hyphens Only: ", index, array[index]);
            index = 0;
            countDigits = 0;
            clearArray(array, ORIGINAL_SIZE);
            scanf("%s",array);
        }
        if(index == ORIGINAL_SIZE && countDigits != 10){
            printf("INVALID NUMBER OF DIGITS %d. Please Enter 10 Digits: ", countDigits);
            index = 0;
            countDigits = 0;
            clearArray(array, ORIGINAL_SIZE);
            scanf("%s",array);
        }       
    }
    //printf("%s", array);
}

Please post a minimal reproducible example. We don't know what validateISBNArray() does. — OldProgrammer
– OldProgrammer, Commented Apr 29, 2017 at 17:19
as stated it has no effect on original array i will post it anyways — Andrei Pak
– Andrei Pak, Commented Apr 29, 2017 at 17:20
You index isbn[index] up to ORIGINAL_SIZE although isbn is declared as int isbn[ISBN_SIZE];. Are you sure this is safe? — aschepler
– aschepler, Commented Apr 29, 2017 at 17:27
you can probably use a debugger - then you might find out the problem with your code yourself. — Muntasir
– Muntasir, Commented Apr 29, 2017 at 17:27
Are you saying that, say, clearArray() does not affect the original array? Hmmm... — Rudy Velthuis
– Rudy Velthuis, Commented Apr 29, 2017 at 17:30

Muntasir · Accepted Answer · 2017-04-30 01:22:06Z

1

Ok I fixed it removing the need for the isbn array

int main(int argc, char *argv[]) {

    char original[ORIGINAL_SIZE];
    int isbn[ISBN_SIZE];
    int index = 0;
    int code;
    int weight = 10;
    int weightedValue;
    int weightedSum = 0;

    printf("Enter an ISBN to validate: ");
    validateISBNArray(original);

    while(index < ORIGINAL_SIZE){
        if(original[index] != '-'){
            if(original[index] == 'x' || original[index] == 'X') code = 10;
            else if(original[index] == 0) code = 0;
            else code = original[index]-48;
            weightedValue = code*weight;
            weight--;
            weightedSum += weightedValue;
        }
        index++;
    }
    if(weightedSum%11==0) printf("The ISBN %s, is VALID", original);
    else printf("The ISBN %s, is NOT VALID", original);

    return 0;
}

edited Apr 30, 2017 at 1:22

Muntasir

8081 gold badge15 silver badges24 bronze badges

answered Apr 29, 2017 at 17:30

Andrei Pak

577 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C Using array values erases array

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related