Remove array of date using another array of date

Question

I'm using MultipleDatePicker to select multiple date in year. I add a checkbox that when checked it will select all sunday in calendar.

I have a problem when unchecked it. It doesn't remove all selected sunday in calendar. I have compared by using getTime() as shown in the code below:

var selected = $scope.selectedDates;

for (var i = 0; i < $scope.selectedDates.length; i++) {
    var date1 = new Date(selected[i]).getTime();
    console.log('date1[' + i + '] = ' + date1 + ' ' + moment($scope.selectedDates[i], 'MM-DD-YYYY'));
    for (var j = 0; j < sundays.length; j++) {
        var date2 = new Date(sundays[j]).getTime();
        console.log('date2[' + j + '] = ' + date2 + ' ' + moment(sundays[j], 'MM-DD-YYYY'));
        if (date1 === date2) {
            selected.splice(i, 1);
            break;
        }
    }
}

Some are the same and some are not. What's wrong with the code?

Here is the plunker to show the problem.

while your problem got resolved already, I think you could have used .isSame for comparing momentJS objects.. current code looks cluttered a bit. — tanmay
– tanmay, Commented May 12, 2017 at 11:04

Milos Popovic · Accepted Answer · 2017-05-12 10:51:26Z

3

The problem is that you removed item from array and your index i has increased in a loop so one item got skipped. To fix this, decrease i after each removal:

    // ...
    if (date1 === date2) {
        selected.splice(i, 1);
        i--;
        break;
    }

answered May 12, 2017 at 10:51

Milos Popovic

1841 silver badge6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Surjeet Bhadauriya · Accepted Answer · 2017-05-12 10:58:37Z

2

Little mistake, you forgot to decrement i, here is updated code.

for (var i = 0; i < $scope.selectedDates.length; i++) {
    var date1 = new Date(selected[i]).getTime();
    console.log('date1[' + i + '] = ' + date1 + ' ' + moment($scope.selectedDates[i], 'MM-DD-YYYY'));
    for (var j = 0; j < sundays.length; j++) {
        var date2 = new Date(sundays[j]).getTime();
        console.log('date2[' + j + '] = ' + date2 + ' ' + moment(sundays[j], 'MM-DD-YYYY'));
        if (date1 === date2) {
            selected.splice(i, 1);
            i--;
            break;
        }
    }
}

answered May 12, 2017 at 10:58

Surjeet Bhadauriya

7,2223 gold badges39 silver badges54 bronze badges

Comments

Leguest · Accepted Answer · 2017-05-12 10:51:33Z

1

I think you forgot about decrement i, when you do splice

 if (date1 === date2) {
    selected.splice(i, 1);
    i = i - 1;
    break;
 }

answered May 12, 2017 at 10:51

Leguest

2,1372 gold badges18 silver badges20 bronze badges

Collectives™ on Stack Overflow

Remove array of date using another array of date

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related