Connection Error while trying to create SQL DB connection from nodejs

Question

While trying to connect SQL DB from a NodeJs class, I am getting an error:

ConnectionError: Connection not yet open

var sql = require("mssql");
var express = require('express');
var bodyParser = require('body-parser');
var app = express();
app.use(bodyParser.json());
var executeQuery = function(res, query) { 

var conn = new sql.ConnectionPool(dbConfig);

conn.connect()
     .then(function (pool) {

         // create Request object
         var request = new sql.Request(pool);                          
         // query to the database
         request.query(query, function (err, queryResult) {
             if (err) {
                 console.log(err);
                 res.send(err);
             } else {
                 res.send(queryResult);
             }
         });
         conn.close();
    });           
}

M3talM0nk3y · Accepted Answer · 2017-08-13 02:14:02Z

1

You're closing the connection before request.query is processed as this is an async call. Move conn.close() inside the callback for request.query.

var conn = new sql.ConnectionPool(dbConfig);

conn.connect()
     .then(function (pool) {

         // create Request object
         var request = new sql.Request(pool);                          
         // query to the database
         request.query(query, function (err, queryResult) {
             if (err) {
                 console.log(err);
                 res.send(err);
             } else {
                 res.send(queryResult);
             }
             conn.close();
         });
    });           
}

answered Aug 13, 2017 at 2:14

M3talM0nk3y

1,43215 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Connection Error while trying to create SQL DB connection from nodejs

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related