OOP PHP set variable value in one function and get from another function

Question

In my class, I am trying to set the value of a variable in a function other than __construct()

But I need that variable value in another function.

Here is what I have tried. But not works Properly.

I expect to print getty images but I get nothing :(

<?php

class MyClass{
    public $var;

    public function __construct(){
        $this->var;
    }

    public function setval(){
        $this->var = 'getty Images';
    }

    public function printval(){
        echo $this->var;
    }
}

$test = new MyClass();
$test->printval();

Why do you expect to print something since you never put anything in $this->var? — axiac
– axiac, Commented Oct 8, 2017 at 17:03

Félix Adriyel Gagnon-Grenier · Accepted Answer · 2017-10-11 18:34:34Z

5

Your constructor does nothing, you need to invoke the method for it to do something.

class MyClass{
    private $var;

    public function __construct() {
        // When the class is called, run the setVal() method
        $this->setval('getty Images');
    }

    public function setval($val) {
        $this->var = $val;
    }

    public function printval() {
        echo $this->var;
    }
}

$test = new MyClass();
$test->printval(); // Prints getty Images

edited Oct 11, 2017 at 18:34

Félix Adriyel Gagnon-Grenier

8,94510 gold badges58 silver badges69 bronze badges

answered Oct 8, 2017 at 16:49

Spoody

2,8821 gold badge29 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Félix Adriyel Gagnon-Grenier Over a year ago

This is like, exactly the same as setting the value in the constructor, except that it's more indirected. Why make simple when you can confuse the hell out of everyone? ;)

Félix Adriyel Gagnon-Grenier Over a year ago

This is not a setter. A setter would be function setValue($v) { $this->value = $v; }. And no, setter injection is not generally better than constructor injection. This is somewhat of a debate, but I literally never use it as it mostly leads only to problems down the road. In this specific case, there is literally no difference as the value is not passed to the setter function. This is dead code. So yeah, my point is that this function should be refactored in the constructor, as it is not actually used outside of the class but in the constructor.

Félix Adriyel Gagnon-Grenier Over a year ago

I... don't know. The question is about setter and getter function. I would rather use the setter function perperly in the constructor (that is, pass 'getty Images' to the setter function $this->setVal('getty Images');, so that setter / getter stays in this answer). If you don't mind me doing it, I'd be happy to oblige.

Spoody Over a year ago

I'm not saying you are wrong actually I'm here to learn more than to give, but OP said i am trying to set value of a variable in a function other than __construct() he insists on setting the value of the var in a method.

Félix Adriyel Gagnon-Grenier Over a year ago

There, I believe I can't express myself, I edited it in a way that, I believe, keeps the setter/getter intent of your answer, answers the question, and actually implements a proper setter getter.

|

JParkinson1991 · Accepted Answer · 2017-10-08 16:49:53Z

1

You need to call your setval() method to actually set a value.

Try:

<?php

$test = new MyClass();
$test->setval();
$test->printval();

If your are happy having a fixed value, setting the variable in the __construct() will work fine and i would recommend this approach.

If however you want a dynamic value you could tweak your setval method to acccept a parameter and save the passed parameter to your object for rendering as part of the printval() call.

answered Oct 8, 2017 at 16:49

JParkinson1991

1,2861 gold badge7 silver badges18 bronze badges

Comments

bishoyN · Accepted Answer · 2017-10-08 16:57:59Z

0

you need first to set value to your variable before you print it

<?php

class MyClass{
    public $var;

    public function setval(){
        $this->var = 'getty Images';
    }

    public function printval(){
        echo $this->var;
    }
}

$test = new MyClass();
$test->setval();
$test->printval();
?>

output:

getty Images

answered Oct 8, 2017 at 16:57

bishoyN

5994 silver badges6 bronze badges

Collectives™ on Stack Overflow

OOP PHP set variable value in one function and get from another function

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related