What am I doing wrong when using string.join in my code?

Question

I have the code below, which I need to separate the result with ", ". I have so far used different methods because whenever I try to use String.Join, it doesn't work as expected. What am I doing wrong?

Code:

using System;
using System.Collections.Generic;
using System.Linq;

namespace _5._PrintEvenNumbers
{
    class Program
    {
        public static void Main()
        {
            var input = Console.ReadLine().Split().Select(int.Parse).ToList();

            var numbers = new Queue<int>();

            for (int i = 0; i < input.Count(); i++)
            {
                if (input[i] % 2 == 0)
                {
                    numbers.Enqueue(input[i]);
                }
            }

            while (numbers.Any())
            {
                Console.Write(string.Join(", ", numbers.Dequeue()));
            }
        }
    }
}

Expected result should be "2, 4, 6" for example. Currently it prints it "246"

Sorry. I had the code updated a bit so it prints every dequeued number. I am typing in(with the current code), 2 4 6 OR 246 and both are resulting in 246, instead of 2, 4, 6 — user9911150
– user9911150, Commented Jan 19, 2019 at 17:46
Numbers.Dequeue takes only one number from queue, so string.Join does not have anything to join. — Karel Kral
– Karel Kral, Commented Jan 19, 2019 at 17:51
You should not put it in loop, just pass a collection to it. — Maytham Fahmi
– Maytham Fahmi, Commented Jan 19, 2019 at 17:52

Camilo Terevinto · Accepted Answer · 2019-01-19 17:59:15Z

3

Just replace

while (numbers.Any())
{
   Console.Write(string.Join(", ", numbers.Dequeue()));
}

with

Console.Write(string.Join(", ", numbers));

Unless you really need to dequeue.

edited Jan 19, 2019 at 17:59

Camilo Terevinto

32.2k7 gold badges95 silver badges127 bronze badges

answered Jan 19, 2019 at 17:50

Sumit raj

8311 gold badge7 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user9911150 Over a year ago

UPDATE: now that you've updated the answer, it actually works. Thanks!

Sumit raj Over a year ago

Sorry it was because i blindly copied the line.

Collectives™ on Stack Overflow

What am I doing wrong when using string.join in my code?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related