PHPUnit: Problem with testing database

Question

I'm new to database testing with PhpUnit. I'm starting with simple test that compare PostgreSQL table's content with xml file.

The problem is that assertion doesn't work as expected:

Please take a look of the result:

http://www3.picturepush.com/photo/a/5540556/1024/Anonymous/Screenshot.png

As you see the tables are equal, but the content in db table(first at screen) has an extra spaces...

I've no idea what is wrong.

Here is PHP code:

public function testGetSourceData()
{
    include_once(
            sfConfig::get('sf_lib_dir')
            . '/task/ShopCategoryTreeUpdateTask.class.php'
    );

    $method = new ReflectionMethod(
      'ShopCategoryTreeUpdateTask', '_getSourceData'
    );

    $method->setAccessible(TRUE);

    $res = $method->invoke(new ShopCategoryTreeUpdateTask(new sfEventDispatcher, new sfFormatter),123);

    $actual = new PHPUnit_Extensions_Database_DataSet_QueryDataSet($this->getConnection());
    $actual->addTable('shop');

    $expected = $this->getDataSet();

    $this->assertDataSetsEqual(
        $actual,
        $expected
    );

}

and here the XML: http://pastebin.com/5MmtJDr6

Thanks for any goals!

Kevin · Accepted Answer · 2011-05-27 08:18:28Z

1

I think you may be over complicating the test. In your method it is likely that QueryDataSet and getDataSet are rendering the result to string differently.

You shouldn't really be testing private and public methods by reflection because these should be testable and accessible by your public methods. If they are not accessibly by public methods then they can never be called. Your code coverage report comes in handy here.

answered May 27, 2011 at 8:18

Kevin

9582 gold badges11 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

tommy_from_breslau Over a year ago

Hi, IMHO that is all correct with testing private and protected methods: sebastian-bergmann.de/archives/881-Testing-Your-Privates.html The result of your suggestions will be good code coverage but not real unit testing. The other thing is that I've answeared about problem with db testing not about sense/problem of testing private or protected methods. Tom

Kevin Over a year ago

Actually, if you read the paragraph near the bottom, he explains his stance on testing private/protected methods and properties "Most of the time, you should be able to test a class by exercising its public methods. If there is significant functionality that is hidden behind private or protected access, that might be a warning sign that there's another class in there struggling to get out" and... "So: Just because the testing of protected and private attributes and methods is possible does not mean that this is a "good thing"."

Collectives™ on Stack Overflow

PHPUnit: Problem with testing database

1 Answer 1

2 Comments

Your Answer

Collectives™ on Stack Overflow

PHPUnit: Problem with testing database

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest