How to ignore click() if an element has a certain class in jQuery?

Question

I know this should be easy stuff, but for some reason the click event is still firing for the element that has a "selected" class.

Can anyone spot the problem with this line?

h.find("li a").not("li a.selected").click(function () {

Phil · Accepted Answer · 2011-05-05 02:31:57Z

5

Use

.not('.selected')

The not() filter applies to the current element

answered May 5, 2011 at 2:31

Phil

166k25 gold badges265 silver badges269 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

daryl · Accepted Answer · 2011-05-05 02:35:15Z

3

$(function() {
    $('div:not[.someclass]').click(function() {
        // do stuff
    });
});

answered May 5, 2011 at 2:35

daryl

15.3k21 gold badges70 silver badges93 bronze badges

6 Comments

Phil Over a year ago

According to the manual, the .not() method is preferred over the :not selector

daryl Over a year ago

@Phil Yeah I'm sure it is. Although this is the method I prefer myself, I even posted this after having saw you posted as I feel its good to get a broader insight of how one thing can be achieved. Regards

James Montagne Over a year ago

Interesting that they would specifically suggest .not(), :not should have better performance.

James Montagne Over a year ago

@phil, No they don't, the .not() is 2 separate calls. It first gets the broader set then filters it. I found a speed test, .not is considerably slower, I'd have to find it again though.

James Montagne Over a year ago

found it jsperf.com/jquery-css3-not-vs-not bigger numbers are better. On small sets of data I'm sure it's negligible. I have had to search over a very large table and found avoiding chaining gave me a reasonable performance increase.

|

Collectives™ on Stack Overflow

How to ignore click() if an element has a certain class in jQuery?

2 Answers 2

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related