PHP for each loop doesn't work if only one result found

Question

I use simplexml to take an xml results page and turn it into an array. Then I use a foreach loop to go through the array records.

The problem is if there is only one result in the array the foreach loop doesnt happen, doesnt display any information.

I have to detect if there is only one row or more than one row and depending on that either use a foreach loop or not.

Wanted to see if there is an easier way so I dont have so much code and everything fits in a foreach loop.

Here is an example:

    $result = $data->params->results;
    $result_count = intval($data->params->totalcount);

    if($result_count > 1)
    {    
        foreach(results AS $curr_result)
        {
            $result_name = $curr_result->name;
        }
    }
    else if($result_count == 1)
    {
        $result_name = $result->name;
    }

Edit: I added the results variable, this is example code and in my hast I didnt go over the code to make sure it was correct. If there is only one result the array looks like this:

  ["fld1"]=>
  string(6) "value1"
  ["fld2"]=>
  string(6) "value2"
  ["fld3"]=>
  string(6) "value3"

If there is more than one result it looks like this:

[0]=>
  ["fld1"]=>
  string(6) "value1"
  ["fld2"]=>
  string(6) "value2"
  ["fld3"]=>
  string(6) "value3"
[1]=>
  ["fld1"]=>
  string(6) "value1"
  ["fld2"]=>
  string(6) "value2"
  ["fld3"]=>
  string(6) "value3"

Again just a quick example, Im sure the code above isnt "correct" per say but it should give enough info to understand what Im talking about.

I'm not sure what the question is here, but I can attest to foreach working when there is only one element in the array. — sdleihssirhc
– sdleihssirhc, Commented May 5, 2011 at 17:50
Not sure if it's just a mis-type, but you're looping over results which isn't a valid variable name, should be $results. — Chris Eberle
– Chris Eberle, Commented May 5, 2011 at 17:50
i would say that this script doesn't work if there is more than one element in array. — tereško
– tereško, Commented May 5, 2011 at 17:51
Yeah, on further inspection, you're looping over results, which isn't a valid variable, and then in the else if block you're referring to $result, and I can't even tell where that's coming from. Very confusing John. — Chris Eberle
– Chris Eberle, Commented May 5, 2011 at 17:53

Doc Kaos · Accepted Answer · 2011-05-06 20:24:15Z

3

You could try:

$results_array = (array)$result;

Which should type cast it to an array, even if it's a single result that was returned.

edited May 6, 2011 at 20:24

user142162

answered May 5, 2011 at 20:31

Doc Kaos

1541 silver badge9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Toby Allen · Accepted Answer · 2011-05-05 17:50:33Z

1

This line

if($result_count > 1)
{

Prevents your foreach loop from running when there is only one item in your array. You want

 if($result_count > 0)
 {

answered May 5, 2011 at 17:50

Toby Allen

11.3k12 gold badges80 silver badges132 bronze badges

Comments

Ibu · Accepted Answer · 2011-05-05 17:55:33Z

1

foreach(results AS $curr_result)

should be:

foreach($results AS $curr_result)

answered May 5, 2011 at 17:55

Ibu

44k14 gold badges82 silver badges109 bronze badges

Comments

John · Accepted Answer · 2011-05-05 18:36:33Z

1

Well this is what I did to get it to work:

$result = $data->params->results;
$result_count = count($result);

if($result_count == 1)
{    
$results_array[0] = $result;
}else
{
$results_array = $result;
}

//loop through $results_array

Sorry if my information wasnt detailed enough and confusing, if you have a better way of doing this please let me know!

answered May 5, 2011 at 18:36

John

10.2k26 gold badges96 silver badges137 bronze badges

Comments

pickypg · Accepted Answer · 2011-05-05 17:50:58Z

0

Your code has a typo in it, and it's not using the array.

$result_name = $results[0]->name;

Just as an FYI, you do realize that the loop in the if statement will simply set $result_name to the last value. It would be easier to do

$result_name = $results[$result_count - 1]->name;

answered May 5, 2011 at 17:50

pickypg

22.4k5 gold badges75 silver badges85 bronze badges

Comments

Andrew · Accepted Answer · 2016-11-16 21:13:25Z

0

Here's what I just did as a clean solution;

I looked for the sub Array first for the multiple elements;

if (isset($data['ComplexArray']['This'][0])) $UseMe = $data['ComplexArray']['This']; else $UseMe[0] = $data['ComplexArray']['This'][0]; foreach ($UseMe as $EachElement) { . . . }

in XML process - by adding the array element, you're not breaking the existing "Foreach" code so you don't have to have "IF (isset($data['ComplexArray']['This'][0])) envelope around the whole "FOREACH" code with redundant code, merely using the existing array logic so it picks up the "one" set element.

edited Nov 16, 2016 at 21:13

answered Sep 22, 2016 at 22:18

Andrew

11 bronze badge

1 Comment

user8397947 Over a year ago

Welcome to Stack Overflow! "Here, use this code" answers aren't generally well received - please edit your answer to explain how does the code in it work.

Collectives™ on Stack Overflow

PHP for each loop doesn't work if only one result found

6 Answers 6

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related