Testing Rail's route's :constraints lambda with RSpec 2

Question

Question:

How do you setup/mock a rspec routing test to look more like a production rack environment?

Bonus points for being able call a controller's authentication function first (eg ApplicationController.authenticate_user to set the session[:current_user_id]

Details:

I am using route :constraints to have www.example.com/ route to two different controllers & views depending on if the user is logged in or not.

root :to => 'intentions#latest', :constraints => lambda {|r| r.env['rack.session'].has_key?(:current_user_id) }
root :to => 'welcome#index'

I wanted to make sure that this bit of fragile routing has a proper test around it. The cukes are testing it but I wanted to do a bit deeper of testing, specifically as I messed up the :current_user_id and the cukes did not catch that. For example I fat fingered :current_user_id in my ApplicationController's authenticate_user() method. Would love to call that in the before(:each) and make sure I am setting the correct session key.

So I created a file called /spec/routing/auth_routing_spec.rb and tried to follow the guide at http://relishapp.com/rspec/rspec-rails/v/2-6-rc/dir/routing-specs. I created the following spec:

it "/ should send me to home page" do
  get('/').should route_to(:controller => :index)
end

When I run the spec I run into this error on the route that has the :constraint. I am assuming that env['rack.session'] does not exists. I tried to mock the request object out via Rails.application.call(Rack::MockRequest.env_for('/')) but that did not help out.

Failure/Error: get('/').should route_to(:controller => :index)
NoMethodError:
  undefined method `has_key?' for nil:NilClass

Boring app details

rake about yields

Ruby version              1.9.2 (x86_64-darwin10.6.0)
RubyGems version          1.6.2
Rack version              1.2
Rails version             3.0.7
Active Record version     3.0.7
Action Pack version       3.0.7
Active Resource version   3.0.7
Action Mailer version     3.0.7
Active Support version    3.0.7

grep rspec gemfile.info yields

remote: git://github.com/rspec/rspec-rails.git
  rspec-rails (2.6.0.rc6)
    rspec (= 2.6.0.rc6)
  rspec (2.6.0.rc6)
    rspec-core (= 2.6.0.rc6)
    rspec-expectations (= 2.6.0.rc6)
    rspec-mocks (= 2.6.0.rc6)
  rspec-core (2.6.0.rc6)
  rspec-expectations (2.6.0.rc6)
  rspec-mocks (2.6.0.rc6)
rspec-rails!

Have you tried creating an env method somewhere in the method chain? So for instance find a class to latch on that might be a parent class of the routing class, and then attach onto that class. This can be easier than trying to shove rack into a test set that doesn't use it. For example AppName::Application.stub(:env).and_return(double(:x => y)) etc. — stuartc
– stuartc, Commented Jun 10, 2012 at 14:47

Matt Van Horn · Accepted Answer · 2012-07-31 22:00:07Z

1

I do something like in my controller specs, maybe the same approach would work here?

describe "some controller" do
  it "does something" do
    request.stub(:env => {'rack.session' => {'current_user' => '42'})
    get :my_action
    response.should be_cool
  end
end

Upon reflection, a better approach for you is probably:

class CurrentUserConstraint
  def self.matches?(request)
    request.session[:current_user_id].present?
  end
end

and:

root :to => 'intentions#latest', :constraints => CurrentUserConstraint.new

and then you have your logic in a class that is easily testable.

edited Jul 31, 2012 at 22:00

answered Jul 31, 2012 at 21:39

Matt Van Horn

1,6441 gold badge12 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Peter Baker Over a year ago

I think the combination of the two is great. Testing the constraint as it's own object is great. Bonus for being able to test the routes as well by stubb'ing the session. Will give it a try this weekend.

Collectives™ on Stack Overflow

Testing Rail's route's :constraints lambda with RSpec 2

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related