C# - use same code for different array length

Question

For my code I have a text file which looks similar like this:

Step1 - * First Move - * Second Move
Step2 - * First Move - * Second Move - * Third Move
Step3 - * First Move
Step4 - * First Move - * Second Move - * Third Move - * Fourth Move

For reading the text file I use the following code:

void Update()
{
     readTextFileLines("fileName", "Step1")
}

[MenuItem("Tools/Read file")]
public void readTextFileLines(string fileName, string Step)
{
    foreach(string line in System.IO.File.ReadAllLines("Assets/Resources/"+fileName+".txt))
    {
        if(line.Contains(Step))
        {
            string[] separator = { "-" };
            string[] strList = line.Split(separator, System.StringSplitOptions.RemoveEmptyEntries);

            //Now I want to show the string in a UI text field.
            //For this I used the following part:

            infoText.text = strList[1] + "\n" + strList[2]

            // So if I have e.g. Step3 I will receive an error.
            // If I have Step2 it will not show the "Third Move"
        }
    }
}

My question now is, how can I rewrite my code, that I do not get the index error?

My first test was with the following code:

for(int i = 1; i < strList.Length; i++)
{
    informationText += strList[i] + "\n";
}

infoText.text = informationText;

but with this code it added way to many lines to my UI text field.

This is how my textfield looks like:

Your "first test" looks correct. Can you tell me, how your output has to look like? — Dennis Meissel
– Dennis Meissel, Commented Jan 13, 2020 at 9:30
You should check what is the length of strList before trying to access items from it.. — Chetan
– Chetan, Commented Jan 13, 2020 at 9:31
@DennisMeissel I added the output as image. Unfortunately I just saw, that I forgot to write that I call de readTextFileLines in Update() — diem_L
– diem_L, Commented Jan 13, 2020 at 9:33
Maybe your informationText variable declared outside of the loop and it gets bigger each iteration? — Dennis Meissel
– Dennis Meissel, Commented Jan 13, 2020 at 9:38

Dennis Meissel · Accepted Answer · 2020-01-13 09:44:45Z

1

Updated method:

[MenuItem("Tools/Read file")]
public void readTextFileLines(string fileName, string Step)
{
    foreach (string line in System.IO.File.ReadAllLines("Assets/Resources/" + fileName + ".txt))
    {
        if (line.Contains(Step))
        {
            string[] separator = { "-" };
            string[] strList = line.Split(separator, System.StringSplitOptions.RemoveEmptyEntries);

            infoText.text = string.Join("\n", strList.Skip(1));
        }
    }
}

answered Jan 13, 2020 at 9:44

Dennis Meissel

2,6632 gold badges27 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

diem_L Over a year ago

this works also perfectly .. thanks a lot. I will use this code, because it is much shorter

Robin Bennett · Accepted Answer · 2020-01-13 09:41:28Z

1

I think your problem is that your code adds a new line at the end of each section. You can avoid it like this:

var thisBit = "";
for(int i = 1; i < strList.Length; i++)
{
    if (thisBit != "") thisBit += "\n";
    thisBit += strList[i];
}
informationText += thisBit;

Or you could use this, which replaces the loop:

informationText += string.Join(strList, "\n");

Or, as all the above basically replaces "-" with "\n", you could use:

infoText.Text = line.Replace("-", "\n");

To trim off the "StepX" part, you could do it like this:

var indexOfStar = line.IndexOf("*");
var moves = line.Substring(indexOfStar);
infoText.Text = moves.Replace("-", "\n");

edited Jan 13, 2020 at 9:41

answered Jan 13, 2020 at 9:34

Robin Bennett

3,2411 gold badge11 silver badges22 bronze badges

3 Comments

diem_L Over a year ago

I used the infoText.Text = line.Replay(...) which worked fine, but now I have the 1. Step1also in my text field :/

Robin Bennett Over a year ago

I've added a bit to show how to remove the 'stepX' part.

diem_L Over a year ago

I tried it with var thisBit = "" this works perfect .. thanks a lot

Anton Anpilogov · Accepted Answer · 2020-01-13 09:37:37Z

0

If I understand you correctly you want to limit your output to the tree lines, so you can combine your condition in loop:

        var moves = "a-b-c-d-e-f-g";
        var strList = moves.Split(new[] {'-'}, StringSplitOptions.RemoveEmptyEntries);
        string informationText = "";

        for(int i = 0; i < strList.Length && i < 3; i++)
            informationText += strList[i] + "\n";

so your output will be like:

  > a
    b
    c

answered Jan 13, 2020 at 9:37

Anton Anpilogov

1415 bronze badges

1 Comment

diem_L Over a year ago

unfortunately not, I want to output all lines (each "-" marks a new line).My code should see if there are 2, 3, 4, 5 or more lines for my text field

Collectives™ on Stack Overflow

C# - use same code for different array length

3 Answers 3

1 Comment

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related