Storing a variable in an array (that functions as a value in an object) JavaScript

Question

I have a simple function that checks if the username already exists in the array of objects, in case it does, it should save new time in an array in format { username: username, time: [firsttime, secondtime, etc] }. The code itself is rough, but the problem is that if the username doesn't exist (and the array is not empty, so there are some other usernames saved already), the function saves the time two times, if I try the same username, I get one more object with double time.

let array = []
const userName = prompt("username")
const userTime = prompt("points")
if (array.length > 0) {
  for (let i = 0; i < array.length; i++) {
    if (array[i].username === userName) {
      array[i].time.push(userTime)
    } else {
      const thisTime = {
        username: userName,
        time: [userTime]
      }
      array.push(thisTime)
    }
  }
} else {
  const firstTime = {
    username: userName,
    time: [userTime]
  }
  array.push(firstTime)
  console.log(array)
}

So on the first round i get [{username: "maria", time: Array(1)}]

On the second round with another username [{username: "maria", time: Array(1)}, {username: "ariana", time: Array(2) e.g. [14,14] (should be only 1 value)}]

The code was edited according to the rules, so actual username and time are added in course of the game.

Please update the snippet I made you with relevant code to make a minimal reproducible example — mplungjan
– mplungjan, Commented Jan 27, 2020 at 14:18
No, you need to update to a working example with a set of example points — mplungjan
– mplungjan, Commented Jan 27, 2020 at 14:40
It would be too much code to write the whole working version, so I have updated to more or less working one. But I already got an answer anyway, thank you. — Maria
– Maria, Commented Jan 27, 2020 at 14:53

Taki · Accepted Answer · 2020-01-27 14:24:27Z

2

You could do that with a more efficient and less error prone way:

// look for the index in the array
const pointIndex = this.points.findIndex(point => point.username === this.username);

if(pointIndex > -1){ // if found, push the time
  this.points[pointIndex].time.push(this.globalTime);
}
else { // push a new point otherwise
  const thisTime = {
    username: this.username,
    time: [this.globalTime]
  }
  this.points.push(thisTime)
}

answered Jan 27, 2020 at 14:24

Taki

17.7k5 gold badges28 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Storing a variable in an array (that functions as a value in an object) JavaScript

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related